[ https://issues.apache.org/jira/browse/OFBIZ-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465406#comment-13465406 ]
Deepak Dixit commented on OFBIZ-2628: ------------------------------------- Hi Sascha, Please add an space in attribute name (like "Test Attr"). I am able to regenerate it over trunk. I am getting following error: <p>Error running the simple-method: Entity value not found with name: lookedUpValue Method = deleteProductAttribute, File = file:/home/ofbiz/trunk/applications/product/script/org/ofbiz/product/product/ProductServices.xml, Element = <remove-value>, Line 961null</p> This is because in delete from url encoding replace space with + symbol. <input type="hidden" value="Test+Attribute" name="attrName"> > No Url encoding for get parameters > ---------------------------------- > > Key: OFBIZ-2628 > URL: https://issues.apache.org/jira/browse/OFBIZ-2628 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: Release Branch 4.0, Release Branch 09.04, SVN trunk > Environment: All > Reporter: Patrick Antivackis > Assignee: Sascha Rodekamp > Priority: Critical > Fix For: Release Branch 11.04, SVN trunk, Release Branch 12.04 > > Attachments: OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch, > OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch, > OFBIZ-2628-encoding-hidden-post-params (list forms).patch, > OFBIZ-2628-encoding-hidden-post-params.patch, > OFBIZ-2628-encoding-request-redirect-params.patch > > Original Estimate: 4h > Remaining Estimate: 4h > > Let's say I want to create a new category which ID is DVD+R > Creation is ok through the admin interface, but whenever i want to access > this category, the get parameter productCategoryId=.... of the url is wrong > as it's not url encoded, so we have : > https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD+R > instead of > https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD%2BR > Both <@ofbizUrl> tag and menu widgets are not encoding get parameters. > Way to correct : > framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java modify the > makeLink function > framework/widget/src/org/ofbiz/widget/WidgetWorker.java : function > buildhyperlinkUrl need to use defaultWebEncoder.encodeForURL instead of > simpleEncoder > Beofre i do the fix, can a core developper let me know about possible side > effects -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira