[
https://issues.apache.org/jira/browse/OFBIZ-3883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488437#comment-13488437
]
John McDonald commented on OFBIZ-3883:
--------------------------------------
Jeff,
Those are excellent suggestions. I wasn't too concerned about modifying the
existing methods as I searched the codebase for all places where it's being
called and only found a few. Based on those situations it didn't appear that it
would impact the intended functionality so I made the change and then tested
the referenced code and didn't immediately uncover any issues. As you know,
though, testing is subjective and it's likely that I missed some test cases. lol
With that being said, I prefer your changes over the ones that I've suggested.
> Customer's Shipment Address Not Assigned to Dropship Purchase Orders
> --------------------------------------------------------------------
>
> Key: OFBIZ-3883
> URL: https://issues.apache.org/jira/browse/OFBIZ-3883
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: Release Branch 10.04, SVN trunk
> Environment: demo-trunk.ofbiz.apache.org
> Reporter: Martin Kreidenweis
> Assignee: Jacques Le Roux
> Attachments: Jira-3883-ShoppingCat.java-patch.txt
>
>
> When buying drop ship products from the demo store the customer's shipping
> address is not saved with the purchase order, so the shipping address cannot
> be provided to the drop ship supplier.
> Steps to Reproduce:
> * From the DropShip Category add "DropShip from BigSupplier" and "DropShip
> from DemoSupplier" to your cart.
> * Login as admin
> * Use the one page checkout to order the products
> Resulting Order:
> https://demo-trunk.ofbiz.apache.org:8443/ordermgr/control/orderview?orderId=WSCO10002
> The purchase orders WS10003 and WS10004 are associated correctly with the
> order items, but as the shipping groups don't have addresses, the purchase
> orders don't have either.
> Expectation:
> All Shipment groups should have the shipping address assigned.
> Actual:
> Only the first shipment group has the shipping address assigned.
> Possibly offending line of Code:
> ShoppingCart.java line 2235:
> this.setShippingContactMechId(0, shippingContactMechId);
> Should probably not add the contactMechId only to the first CartShipInfo.
> When we tried to change that, though, drop shipping broke somehow completely.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
