I think we should complete the migration from bsh scripts: to groovy: scripts
and then we could remove the Beanshell specific code and jars from the trunk.
What do you think?
Jacopo
On Apr 5, 2013, at 10:11 AM, Adrian Crum <adrian.c...@sandglass-software.com>
wrote:
> Oh! Thanks for the clarification.
>
> -Adrian
>
> On 4/5/2013 8:45 AM, Jacopo Cappellato wrote:
>> Adrian,
>>
>> I think that Nicolas was proposing to replace " with ' to increase
>> readability: this was not possible with Beanshell but it is now possible
>> after we switch to groovy.
>>
>> Jacopo
>>
>>
>>
>> On Apr 5, 2013, at 9:26 AM, Adrian Crum <adrian.c...@sandglass-software.com>
>> wrote:
>>
>>> We will see if anyone reports a problem. I ran unit tests after the
>>> replacement (the unit tests used the bsh: scriptlets a lot) and there were
>>> no errors reported.
>>>
>>> -Adrian
>>>
>>> On 4/5/2013 7:59 AM, Nicolas Malin wrote:
>>>> Hi adrian,
>>>>
>>>> There is a risk to change " by ' when we change bsh by groovy engine
>>>> on flexible string ?
>>>> When I convert old customer specific code as you did, I replace also the
>>>> string " .
>>>>
>>>> productMaintValue.getBigDecimal('intervalQuantity') is really more
>>>> readable than productMaintValue.getBigDecimal("intervalQuantity")
>>>>
>>>> Just to be sure that I didn't to take a wrong way.
>>>>
>>>> Cheers,
>>>> Nicolas
>>>>
>>>> Le 05/04/2013 00:01, adri...@apache.org a écrit :
>>>>> - <set field="nextIntervalQty"
>>>>> value="${bsh:maxIntervalQty.add(productMaintValue.getBigDecimal("intervalQuantity"));}"
>>>>> type="BigDecimal"/>
>>>>> + <set field="nextIntervalQty"
>>>>> value="${groovy:maxIntervalQty.add(productMaintValue.getBigDecimal("intervalQuantity"));}"
>>>>> type="BigDecimal"/>
>>>>
>
