[ 
https://issues.apache.org/jira/browse/OFBIZ-5179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13646204#comment-13646204
 ] 

Mirko Vogelsmeier commented on OFBIZ-5179:
------------------------------------------

Hello Carsten,
i did reviewed the function of the paypal interface just some months ago and it 
worked fine for me.
"PayPal contiditions are met" is a little to abstract to exactly point out a 
bug there might be.

About simple methods: I rather guess that the interface integration is not 
designed to use the OFBiz Simple-Methods (which to be honest im pretty glad 
about :D ). Or did i missinterpret the problem?

CheckOutEvents#checkExternalPayment checks the defined OrderPaymentPref for the 
currently definied paymentMethod. Maybe your issue is while creating / working 
with the order?

It would be helpfull if you create tickets for concrete problems (eg. 
inconsistent ways to get a locale) and refere to the users mailinglist for 
configuration issues with payment-regarding issues.

Greetings,
Mirko

                
> checkExternalPayment returns payflowpro instead of paypal
> ---------------------------------------------------------
>
>                 Key: OFBIZ-5179
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5179
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>         Environment: independant
>            Reporter: Carsten Schinzer
>             Fix For: SVN trunk
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The following method contains a false return value:
> org.ofbiz.order.schoppingcart.CheckOutEvents#checkExternalPayment
> It verifies a Paypal payment method is defined for the ProductStore, but then 
> returns a value 'payflowpro' in return which is clearly false as PayFlowPro 
> is a separate external payment method.
> The patch/fix will allow to check for both, PayPal and PayFlowPro as external 
> payment methods.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to