Russell Morrisey created OFBIZ-5196: ---------------------------------------
Summary: TemporalExpressions$DayOfWeekRange: copy+paste logic errors Key: OFBIZ-5196 URL: https://issues.apache.org/jira/browse/OFBIZ-5196 Project: OFBiz Issue Type: Bug Affects Versions: SVN trunk Reporter: Russell Morrisey TemporalExpressions$DayOfWeekRange contains incorrect code which appears to be copied-and-pasted from DayOfMonthRange. It adds months to the calendar object, where weeks or days should be used. Example (TemporalExpressions.java, 412-419): @Override public Calendar first(Calendar cal) { Calendar first = (Calendar) cal.clone(); while (!includesDate(first)) { first.add(Calendar.DAY_OF_MONTH, 1); //This is wrong } return first; } This problem appears in several places throughout this inner class. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira