[ https://issues.apache.org/jira/browse/OFBIZ-5211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13679025#comment-13679025 ]
Jacques Le Roux commented on OFBIZ-5211: ---------------------------------------- Hi Leon, I reviewed and it seemed OK to me. But I tested and surprisingly it's not finally, maybe a js quirk (I used FF 21) If I set widget.lookup.showDescription=N, by default, I should not see the lookups descriptions, right? I tried, after a compilation, I still see the lookups descriptions on the example/control/FormWidgetExamples page. Notes: # I would cut the xsd doc lines, like this {code} <xs:attribute name="show-description" type="xs:boolean"> <xs:annotation> <xs:documentation>If true, a special span with css class "tooltip" will be created at right of the lookup button and a description will fill in. If not set then it depends on the "widget.lookup.showDescription" setting. </xs:documentation> </xs:annotation> </xs:attribute> {code} # I'd use Y and not N as default for (I know it was like that, but it's not consistent with the default property, so while at it...) {code} showDescription = "Y".equals(UtilProperties.getPropertyValue("widget", "widget.lookup.showDescription", "Y")); {code} > Make "showDescription" of <lookup> filed configurable individually > ------------------------------------------------------------------ > > Key: OFBIZ-5211 > URL: https://issues.apache.org/jira/browse/OFBIZ-5211 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Leon > Priority: Minor > Attachments: OFBIZ-5211.patch > > > For now, It's configured globally through "widget.lookup.showDescription" in > widget.properties. > In some case, we want to disable this feature for particular <lookup> filed. > So we try to make it enabled. > 1. update the widget-form.xsd to add new attribute "show-description" to > <lookup> filed > * if set this attribute explicitly to true or false, then showDescription > feature is enabled or disabled respectively > * if this attribute is not set (default), then showDescription or not > depends on the "widget.lookup.showDescription" setting > 2. modify ModelFormField and MacroFormRenderer to make it works -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira