[
https://issues.apache.org/jira/browse/OFBIZ-4794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13693319#comment-13693319
]
Jacques Le Roux commented on OFBIZ-4794:
----------------------------------------
I see drawbacks with patches
* it's not as flexible as a command line parameter when you need to deliver a
random port number (see Olivier Lamy's request above for instance)
* I especially foresee that, again, I will be the one who will handle this for
tests and demos (maybe Christian will help, thanks to him). And if it's the
case, then I far prefer to use a command line parameter than patches on a
committer account (you mean something like https://people.apache.org/~lectran,
right?). Else why not, if other persons want to invest in regularly supporting
tests and demos, you are warmly welcomed :)
>I doubt you foresaw this config change either until people started talking
>about problems with Jenkins so I'm not sure that your argument is valid.
Wrong, I foresaw this change long ago. When I worked with Geronimo, were they
use a such port offset parameter. I found it a great and flexible idea. You can
find it here at least http://markmail.org/message/og7zgvclh64vzlq7, there are
other occurences of this idea, just look for
http://ofbiz.markmail.org/search/?q=port+offset. The idea is to use a single
offset value to changes all ports values in a single shoot. That's where it's
different from all others config.
Anyway, I can agree about providing an ant target to apply ports offset before
running an instance (either in demo or test mode). This would be notably easier
for instance than changing url.properties value in
RequestHandler.getDefaultServerRootUrl()
So, what's next?
> set different ports for testing in a CI environment (e.g. Jenkins)
> ------------------------------------------------------------------
>
> Key: OFBIZ-4794
> URL: https://issues.apache.org/jira/browse/OFBIZ-4794
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Pierre Smits
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4794 - test port.patch, OFBIZ-4794-test-ports.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> In order to run test targets in Jenkins we need to change ports for at least
> ajp, http and https in test-containers.xml as these ports are most likely to
> be already in use by the CI server.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
