[ 
https://issues.apache.org/jira/browse/OFBIZ-4794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13694556#comment-13694556
 ] 

Jacques Le Roux edited comment on OFBIZ-4794 at 6/27/13 8:45 AM:
-----------------------------------------------------------------

=== FORGOT A 4th point ===
# Ha sorry indeed, I did not mean port offset in this way. I meant the way you 
suggested of course (would not make sense anyway, what would be a port offset 
patch?). Something like
{code}
Index: ofbiz-component.xml
===================================================================
--- ofbiz-component.xml (revision 1493331)
+++ ofbiz-component.xml (working copy)
@@ -34,7 +34,7 @@
     <!-- load the naming (JNDI) server -->
     <container name="naming-container" loaders="rmi" 
class="org.ofbiz.base.container.NamingServiceContainer">
         <property name="host" value="0.0.0.0"/>
-        <property name="port" value="1099"/>
+        <property name="port" value="21099"/>
     </container>
 
     <!-- load BeanShell remote telnet server -->
{code}
# Work for me? You must be kidding!

Anyway, thanks for you comments Adrian and Scott. But I will do as I want 
mostly because:
# I don't like much the complicated idea of maintaining patches in one 
committers people folder, or any places anyway
# I know I'm the one who will eventually have to support it
# I'm not convinced that the patch I proposed will be annoying for anybody and 
I don't foresee much config changes again in the future
# This will allow to see what we can do for the Sonar Infra task pending, where 
they want a possible random port setting



                
      was (Author: jacques.le.roux):
    # Ha sorry indeed, I did not mean port offset in this way. I meant the way 
you suggested of course (would not make sense anyway, what would be a port 
offset patch?). Something like
{code}
Index: ofbiz-component.xml
===================================================================
--- ofbiz-component.xml (revision 1493331)
+++ ofbiz-component.xml (working copy)
@@ -34,7 +34,7 @@
     <!-- load the naming (JNDI) server -->
     <container name="naming-container" loaders="rmi" 
class="org.ofbiz.base.container.NamingServiceContainer">
         <property name="host" value="0.0.0.0"/>
-        <property name="port" value="1099"/>
+        <property name="port" value="21099"/>
     </container>
 
     <!-- load BeanShell remote telnet server -->
{code}
# Work for me? You must be kidding!

Anyway, thanks for you comments Adrian and Scott. But I will do as I want 
mostly because:
# I don't like much the complicated idea of maintaining patches in one 
committers people folder, or any places anyway
# I know I'm the one who will eventually have to support it
# I'm not convinced that the patch I proposed will be annoying for anybody and 
I don't foresee much config changes again in the future



                  
> set different ports for testing in a CI environment (e.g. Jenkins)
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-4794
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4794
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Pierre Smits
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4794 - test port.patch, OFBIZ-4794-test-ports.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> In order to run test targets in Jenkins we need to change ports for at least 
> ajp, http and https in test-containers.xml as these ports are most likely to 
> be already in use by the CI server.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to