Hi Adrian, These controller request has "event", and if an request event attribute is not null then WidgetWorker.determineAutoLinkType() return hidden-form as link type and its create an empty form for the same. WidgetWorker method convert hyper links to hidden for for service type of event as we allow only post parameter for service.
Thanks & Regards -- Deepak Dixit HotWax Media Pvt. Ltd. www.hotwaxmedia.com Contact :- +91-98267-54548 Skype :- deepakdixit On Jul 5, 2013, at 4:32 PM, Adrian Crum wrote: > This doesn't make sense. Why are those two menu items exceptions to the rule? > > -Adrian > > On 7/5/2013 7:57 AM, jler...@apache.org wrote: >> Author: jleroux >> Date: Fri Jul 5 06:57:03 2013 >> New Revision: 1499918 >> >> URL: http://svn.apache.org/r1499918 >> Log: >> A patch from Deepak Dixit for "Application Menu items should be link not >> hidden form." https://issues.apache.org/jira/browse/OFBIZ-4913 >> >> Application menu item should be link not hidden form. As if its hidden form >> then you can not open it in new tab. >> Default menu item link type auto, and its create an hidden for for link if >> controller request call an event, but in menu item this should be link. >> >> Modified: >> ofbiz/trunk/applications/marketing/widget/sfa/SfaMenus.xml >> ofbiz/trunk/applications/order/widget/ordermgr/OrderMenus.xml >> >> Modified: ofbiz/trunk/applications/marketing/widget/sfa/SfaMenus.xml >> URL: >> http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/SfaMenus.xml?rev=1499918&r1=1499917&r2=1499918&view=diff >> ============================================================================== >> --- ofbiz/trunk/applications/marketing/widget/sfa/SfaMenus.xml (original) >> +++ ofbiz/trunk/applications/marketing/widget/sfa/SfaMenus.xml Fri Jul 5 >> 06:57:03 2013 >> @@ -28,7 +28,7 @@ under the License. >> <menu-item name="Forecast" title="${uiLabelMap.SfaForecasts}"><link >> target="FindSalesForecast"/></menu-item> >> <menu-item name="Opportunities" >> title="${uiLabelMap.SfaOpportunities}"><link >> target="FindSalesOpportunity"/></menu-item> >> <menu-item name="Preferences" >> title="${uiLabelMap.CommonPreferences}" align-style="opposed"> >> - <link target="ManagePortalPages"> >> + <link target="ManagePortalPages" link-type="anchor"> >> <parameter param-name="parentPortalPageId" >> from-field="parameters.parentPortalPageId"/> >> </link> >> </menu-item> >> >> Modified: ofbiz/trunk/applications/order/widget/ordermgr/OrderMenus.xml >> URL: >> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/widget/ordermgr/OrderMenus.xml?rev=1499918&r1=1499917&r2=1499918&view=diff >> ============================================================================== >> --- ofbiz/trunk/applications/order/widget/ordermgr/OrderMenus.xml (original) >> +++ ofbiz/trunk/applications/order/widget/ordermgr/OrderMenus.xml Fri Jul 5 >> 06:57:03 2013 >> @@ -60,7 +60,7 @@ under the License. >> <if-has-permission permission="ORDERMGR" >> action="_PURCHASE_CREATE"/> >> </or> >> </condition> >> - <link target="orderentry"/> >> + <link target="orderentry" link-type="anchor"/> >> </menu-item> >> <menu-item name="return" title="${uiLabelMap.OrderOrderReturns}"> >> >> >
smime.p7s
Description: S/MIME cryptographic signature
