I am sorry Adrian, this is not a pretty screen,

https://localhost:8443/accounting/control/EditFixedAsset

i prefer the screen with a screenlet as really many, many others. I would like to change your screen too :-)

Regards,
Hans



On 07/05/2013 06:49 PM, Adrian Crum wrote:
Making screens consistent is a good idea, but please make them consistent with GOOD layouts, not with BAD layouts. Please follow the best practices.

https://localhost:8443/accounting/control/EditFixedAsset

-Adrian

On 7/5/2013 12:46 PM, Hans Bakker wrote:
to make the screen layout consistent to:
https://localhost:8443/accounting/control/ListCompanies
https://localhost:8443/accounting/control/globalGLSettings
https://localhost:8443/accounting/control/editInvoiceItemType
https://localhost:8443/accounting/control/editPaymentMethodType
https://localhost:8443/accounting/control/FindGlobalGlAccount

and many, many others.....

Regards,
Hans

On 07/05/2013 06:24 PM, Adrian Crum wrote:
Please don't do this. Screenlets are used to divide sections of a screen in a multi-purpose screen. This screen appears to have a single purpose.

https://cwiki.apache.org/confluence/display/OFBADMIN/User+Interface+Layout+Best+Practices

-Adrian

On 7/5/2013 9:04 AM, hans...@apache.org wrote:
Author: hansbak
Date: Fri Jul  5 08:04:07 2013
New Revision: 1499927

URL: http://svn.apache.org/r1499927
Log:
add screenlet to add accounting company screen

Modified:
ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml

Modified: ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml?rev=1499927&r1=1499926&r2=1499927&view=diff ============================================================================== --- ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml (original) +++ ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml Fri Jul 5 08:04:07 2013
@@ -86,7 +86,9 @@ under the License.
              <widgets>
<decorator-screen name="main-decorator" location="${parameters.mainDecoratorLocation}">
                      <decorator-section name="body">
- <include-form name="AddCompany" location="component://accounting/widget/GlSetupForms.xml"/> + <screenlet title="${uiLabelMap.AccountingNewCompany}"> + <include-form name="AddCompany" location="component://accounting/widget/GlSetupForms.xml"/>
+                        </screenlet>
                      </decorator-section>
                  </decorator-screen>
              </widgets>






Reply via email to