[ 
https://issues.apache.org/jira/browse/OFBIZ-4291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13701290#comment-13701290
 ] 

Ankit Jain commented on OFBIZ-4291:
-----------------------------------

Hi Nandani,

I got your question, we need to update the method to deal with all the rules, 
like in your case if its a gift that will be added in cart, so we have to 
remove that product if we unapply the promotion. 

We need to write the logic to handle all the rules. And if someone upapply the 
promotion then remove the product or discount accordingly, based on the rules 
in the promotion.

I'll try to find some time to give one more patch which handles all the rules 
in the promotion. Or you can also contribute, if you are planning.

Thanks.
                
> No method to remove a promo code from the shopping cart
> -------------------------------------------------------
>
>                 Key: OFBIZ-4291
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4291
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: Release Branch 10.04
>            Reporter: Glyton Camilleri
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: unapplyPromotion.txt, Updated-Ofbiz-4291.patch, 
> Updated-Ofbiz-4291.patch
>
>
> Hi,
> When working with promotions and promo codes in the shopping cart, it seems 
> not possible to remove _one_ specific promo code from the cart neither 
> through the ShoppingCart and its helpers and services, nor through the 
> ProductPromoWorker.
> ShoppingCart has the method 
> {{addProductPromoCode(String productPromoCodeId, LocalDispatcher dispatcher)}}
> but no method to remove the added PromoCode. Is there any other worker, 
> service or event that can be called to do this? And if not, is there a 
> specifc reason (maybe relating to promotions application rules) for not 
> implementing this?
> Any response is appreciated.
> Thanks

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to