Ahh.

So no JIRA issue. Just a few remarks by one other person in a mail thread
on development. No interaction with the community. No sollicitation to
interact. And presto pronto it is gone from trunk.

Well done!

Pierre Smits


On Mon, Jul 8, 2013 at 2:54 PM, Adrian Crum <
adrian.c...@sandglass-software.com> wrote:

> http://mail-archives.apache.**org/mod_mbox/ofbiz-dev/201306.**
> mbox/%3C51BD738D.1000507@**sandglass-software.com%3E<http://mail-archives.apache.org/mod_mbox/ofbiz-dev/201306.mbox/%3c51bd738d.1000...@sandglass-software.com%3E>
>
> -Adrian
>
>
> On 7/8/2013 8:29 AM, Pierre Smits wrote:
>
>> Removing code from trunk without consulting others before the removal,
>> without preservation of functionality (if it actually works) is bad form.
>>
>> Pierre Smits
>>
>>
>> On Sun, Jul 7, 2013 at 4:22 PM, Jacques Le Roux <
>> jacques.le.r...@les7arts.com> wrote:
>>
>>  This could maybe be kept as an addon?
>>>
>>> https://code.google.com/a/**apache-extras.org/p/ofbiz-adm/**
>>> wiki/DiscoverAddonOn15Minutes<https://code.google.com/a/apache-extras.org/p/ofbiz-adm/wiki/DiscoverAddonOn15Minutes>
>>>
>>> Jacques
>>>
>>> From: <adri...@apache.org>
>>>
>>>> Author: adrianc
>>>> Date: Sun Jul  7 13:05:14 2013
>>>> New Revision: 1500424
>>>>
>>>> URL: http://svn.apache.org/r1500424
>>>> Log:
>>>> Removed the XSD-to-Java feature. Tools to make OFBiz development easier
>>>>
>>> are outside the scope of the project.
>>>
>>>> Removed:
>>>>     ofbiz/trunk/framework/**webtools/webapp/webtools/**XsdToJava.ftl
>>>> Modified:
>>>>     ofbiz/trunk/framework/**webtools/config/**WebtoolsUiLabels.xml
>>>>     ofbiz/trunk/framework/**webtools/webapp/webtools/WEB-**
>>>> INF/controller.xml
>>>>     ofbiz/trunk/framework/**webtools/webapp/webtools/main.**ftl
>>>>     ofbiz/trunk/framework/**webtools/widget/MiscForms.xml
>>>>     ofbiz/trunk/framework/**webtools/widget/MiscScreens.**xml
>>>>
>>>> Modified: ofbiz/trunk/framework/**webtools/config/**
>>>> WebtoolsUiLabels.xml
>>>> URL:
>>>>
>>> http://svn.apache.org/viewvc/**ofbiz/trunk/framework/**webtools/config/*
>>> *WebtoolsUiLabels.xml?rev=**1500424&r1=1500423&r2=1500424&**view=diff<http://svn.apache.org/viewvc/ofbiz/trunk/framework/webtools/config/WebtoolsUiLabels.xml?rev=1500424&r1=1500423&r2=1500424&view=diff>
>>> ==============================**==============================**
>>> ==================
>>>
>>>> --- ofbiz/trunk/framework/**webtools/config/**WebtoolsUiLabels.xml
>>>> (original)
>>>> +++ ofbiz/trunk/framework/**webtools/config/**WebtoolsUiLabels.xml Sun
>>>> Jul
>>>>
>>>   7 13:05:14 2013
>>>
>>>> @@ -5823,19 +5823,4 @@
>>>>          <value xml:lang="zh">创建一个å®**žä½“ ${entityName}
>>>>
>>> ï¼šè¾“å…¥å€¼ï¼Œç„¶å Žç‚¹å‡»æ–°å»º.</value>
>>>
>>>>          <value xml:lang="zh_TW">創建一個**實體 ${entityName}
>>>>
>>> :輸入值,然後點擊新**建.</value>
>>>
>>>>      </property>
>>>> -    <property key="WebtoolsXsdToJava">
>>>> -        <value xml:lang="en">XSD to Java</value>
>>>> -    </property>
>>>> -    <property key="WebtoolsXsdFileName">
>>>> -        <value xml:lang="en">XSD File Name</value>
>>>> -    </property>
>>>> -    <property key="WebtoolsPackageName">
>>>> -        <value xml:lang="en">Package Name</value>
>>>> -    </property>
>>>> -    <property key="**WebtoolsExceptionClassName">
>>>> -        <value xml:lang="en">Exception Class Name</value>
>>>> -    </property>
>>>> -    <property key="WebtoolsVisitorClassName"**>
>>>> -        <value xml:lang="en">Visitor Class Name</value>
>>>> -    </property>
>>>> </resource>
>>>>
>>>> Modified:
>>>>
>>> ofbiz/trunk/framework/**webtools/webapp/webtools/WEB-**
>>> INF/controller.xml
>>>
>>>> URL:
>>>>
>>> http://svn.apache.org/viewvc/**ofbiz/trunk/framework/**
>>> webtools/webapp/webtools/WEB-**INF/controller.xml?rev=**
>>> 1500424&r1=1500423&r2=1500424&**view=diff<http://svn.apache.org/viewvc/ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/controller.xml?rev=1500424&r1=1500423&r2=1500424&view=diff>
>>> ==============================**==============================**
>>> ==================
>>>
>>>> ---
>>>>
>>> ofbiz/trunk/framework/**webtools/webapp/webtools/WEB-**
>>> INF/controller.xml
>>> (original)
>>>
>>>> +++
>>>>
>>> ofbiz/trunk/framework/**webtools/webapp/webtools/WEB-**INF/controller.xml
>>> Sun
>>> Jul  7 13:05:14 2013
>>>
>>>> @@ -609,11 +609,6 @@ under the License.
>>>>          <response name="success" type="view"
>>>> value="WebtoolsLayoutDemo"/>
>>>>      </request-map>
>>>>
>>>> -    <request-map uri="XsdToJava">
>>>> -        <security https="true" auth="true"/>
>>>> -        <response name="success" type="view" value="XsdToJava"/>
>>>> -    </request-map>
>>>> -
>>>>      <!-- end of request mappings -->
>>>>
>>>>      <!-- View Mappings -->
>>>> @@ -715,7 +710,6 @@ under the License.
>>>>      <view-map name="LookupGeo" type="screen"
>>>>
>>> page="component://webtools/**widget/GeoManagementScreens.**
>>> xml#LookupGeo"/>
>>>
>>>>      <view-map name="WebtoolsLayoutDemo"
>>>>
>>> page="component://webtools/**widget/MiscScreens.xml#**
>>> WebtoolsLayoutDemo"
>>> type="screen"/>
>>>
>>>> -    <view-map name="XsdToJava"
>>>>
>>> page="component://webtools/**widget/MiscScreens.xml#**XsdToJava"
>>> type="screen"/>
>>>
>>>>      <!-- end of view mappings -->
>>>> </site-conf>
>>>>
>>>> Modified: ofbiz/trunk/framework/**webtools/webapp/webtools/main.**ftl
>>>> URL:
>>>>
>>> http://svn.apache.org/viewvc/**ofbiz/trunk/framework/**
>>> webtools/webapp/webtools/main.**ftl?rev=1500424&r1=1500423&r2=**
>>> 1500424&view=diff<http://svn.apache.org/viewvc/ofbiz/trunk/framework/webtools/webapp/webtools/main.ftl?rev=1500424&r1=1500423&r2=1500424&view=diff>
>>> ==============================**==============================**
>>> ==================
>>>
>>>> --- ofbiz/trunk/framework/**webtools/webapp/webtools/main.**ftl
>>>> (original)
>>>> +++ ofbiz/trunk/framework/**webtools/webapp/webtools/main.**ftl Sun
>>>> Jul  7
>>>>
>>> 13:05:14 2013
>>>
>>>> @@ -44,7 +44,6 @@ under the License.
>>>>            <li><a href="<@ofbizUrl>ArtifactInfo<**/@ofbizUrl>"
>>>>
>>> target="_blank">${uiLabelMap.**WebtoolsArtifactInfo}</a></li>
>>>
>>>>            <li><a href="<@ofbizUrl>entityref</@**ofbizUrl>"
>>>>
>>> target="_blank">${uiLabelMap.**WebtoolsEntityReference} -
>>> ${uiLabelMap.**WebtoolsEntityReferenceInterac**tiveVersion}</a></li>
>>>
>>>>            <li><a
>>>>
>>> href="<@ofbizUrl>ServiceList</**@ofbizUrl>">${uiLabelMap.**
>>> WebtoolsServiceReference}</a><**/li>
>>>
>>>> -          <li><a
>>>>
>>> href="<@ofbizUrl>XsdToJava</@**ofbizUrl>">${uiLabelMap.**
>>> WebtoolsXsdToJava}</a></li>
>>>
>>>>          </#if>
>>>>          <#if security.hasPermission("LABEL_**MANAGER_VIEW", session)>
>>>>            <li><h3>${uiLabelMap.**WebtoolsLabelManager}</h3></**li>
>>>>
>>>> Modified: ofbiz/trunk/framework/**webtools/widget/MiscForms.xml
>>>> URL:
>>>>
>>> http://svn.apache.org/viewvc/**ofbiz/trunk/framework/**
>>> webtools/widget/MiscForms.xml?**rev=1500424&r1=1500423&r2=**
>>> 1500424&view=diff<http://svn.apache.org/viewvc/ofbiz/trunk/framework/webtools/widget/MiscForms.xml?rev=1500424&r1=1500423&r2=1500424&view=diff>
>>> ==============================**==============================**
>>> ==================
>>>
>>>> --- ofbiz/trunk/framework/**webtools/widget/MiscForms.xml (original)
>>>> +++ ofbiz/trunk/framework/**webtools/widget/MiscForms.xml Sun Jul  7
>>>>
>>> 13:05:14 2013
>>>
>>>> @@ -70,23 +70,4 @@ under the License.
>>>>          </field>
>>>>      </form>
>>>>
>>>> -    <form name="XsdToJavaForm" type="single" target="XsdToJava"
>>>>
>>> default-map-name="parameters">
>>>
>>>> -        <field name="xsdFileName"
>>>>
>>> title="${uiLabelMap.**WebtoolsXsdFileName}" widget-style="required"
>>> tooltip="${uiLabelMap.**CommonRequired}">
>>>
>>>> -            <text />
>>>> -        </field>
>>>> -        <field name="packageName"
>>>>
>>> title="${uiLabelMap.**WebtoolsPackageName}">
>>>
>>>> -            <text />
>>>> -        </field>
>>>> -        <field name="exceptionClassName"
>>>>
>>> title="${uiLabelMap.**WebtoolsExceptionClassName}">
>>>
>>>> -            <text />
>>>> -        </field>
>>>> -        <field name="visitorClassName"
>>>>
>>> title="${uiLabelMap.**WebtoolsVisitorClassName}">
>>>
>>>> -            <text />
>>>> -        </field>
>>>> -        <field name="submitButton"
>>>>
>>> title="${uiLabelMap.**CommonCreate}"><submit
>>> button-type="button"/></field>
>>>
>>>> -        <field name="cancelButton" title=" "
>>>> widget-style="smallSubmit">
>>>> -            <hyperlink target="main"
>>>>
>>> description="${uiLabelMap.**CommonCancel}"></hyperlink>
>>>
>>>> -        </field>
>>>> -    </form>
>>>> -
>>>> </forms>
>>>>
>>>> Modified: ofbiz/trunk/framework/**webtools/widget/MiscScreens.**xml
>>>> URL:
>>>>
>>> http://svn.apache.org/viewvc/**ofbiz/trunk/framework/**
>>> webtools/widget/MiscScreens.**xml?rev=1500424&r1=1500423&r2=**
>>> 1500424&view=diff<http://svn.apache.org/viewvc/ofbiz/trunk/framework/webtools/widget/MiscScreens.xml?rev=1500424&r1=1500423&r2=1500424&view=diff>
>>> ==============================**==============================**
>>> ==================
>>>
>>>> --- ofbiz/trunk/framework/**webtools/widget/MiscScreens.**xml
>>>> (original)
>>>> +++ ofbiz/trunk/framework/**webtools/widget/MiscScreens.**xml Sun Jul
>>>>  7
>>>>
>>> 13:05:14 2013
>>>
>>>> @@ -222,46 +222,4 @@ under the License.
>>>>          </section>
>>>>      </screen>
>>>>
>>>> -    <screen name="XsdToJava">
>>>> -        <section>
>>>> -            <actions>
>>>> -                <set field="headerItem" value="main" />
>>>> -                <set field="titleProperty" value="WebtoolsXsdToJava" />
>>>> -                <set field="xsdFileName"
>>>>
>>> from-field="parameters.**xsdFileName" />
>>>
>>>> -                <set field="packageName"
>>>>
>>> from-field="parameters.**packageName" default-value="org.ofbiz.*" />
>>>
>>>> -                <set field="exceptionClassName"
>>>>
>>> from-field="parameters.**exceptionClassName"
>>> default-value="ModelException" />
>>>
>>>> -                <set field="visitorClassName"
>>>>
>>> from-field="parameters.**visitorClassName" />
>>>
>>>> -            </actions>
>>>> -            <widgets>
>>>> -                <decorator-screen name="main-decorator"
>>>>
>>> location="${parameters.**mainDecoratorLocation}">
>>>
>>>> -                    <decorator-section name="body">
>>>> -                        <container style="page-title">
>>>> -
>>>>
>>>   <label>${uiLabelMap.**WebtoolsXsdToJava}</label>
>>>
>>>> -                        </container>
>>>> -                        <include-form name="XsdToJavaForm"
>>>>
>>> location="component://**webtools/widget/MiscForms.xml" />
>>>
>>>> -                        <section>
>>>> -                            <condition>
>>>> -                                <not>
>>>> -                                    <if-empty field="xsdFileName" />
>>>> -                                </not>
>>>> -                            </condition>
>>>> -                            <actions>
>>>> -                                <set field="xsdRootElement"
>>>>
>>> value="${groovy:org.ofbiz.**base.config.ResourceLoader.**
>>> getXmlRootElement(xsdFileName)**}"
>>> />
>>>
>>>> -                            </actions>
>>>> -                            <widgets>
>>>> -                                <screenlet>
>>>> -                                    <platform-specific>
>>>> -                                        <html>
>>>> -                                            <html-template
>>>>
>>> location="component://**webtools/webapp/webtools/**XsdToJava.ftl" />
>>>
>>>> -                                        </html>
>>>> -                                    </platform-specific>
>>>> -                                </screenlet>
>>>> -                            </widgets>
>>>> -                        </section>
>>>> -                    </decorator-section>
>>>> -                </decorator-screen>
>>>> -            </widgets>
>>>> -        </section>
>>>> -    </screen>
>>>> -
>>>> </screens>
>>>>
>>>>
>>>>
>

Reply via email to