[ https://issues.apache.org/jira/browse/OFBIZ-5312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13797683#comment-13797683 ]
Pierre Smits commented on OFBIZ-5312: ------------------------------------- In SeoContextFilter.java with following excerpt of code: List<GenericValue> tenants = delegator.findList("Tenant", EntityCondition.makeCondition("domainName", serverName), null, UtilMisc.toList("-createdStamp"), null, false); it is tried to get the tenantId from the values in entity Tenant based on the assumption that the serverName (coming from httpRequest.getServerName() ) equals the domainName in the tenant record. However, following possibilities may and can occur: 1. no domainName is set in the tenant record, 2. a domainName is set, but is different than the serverName resolved 3. a tenant has multiple ecommerce websites (serverNames) - in combination with the above 2 points, The domainName on the tenant record was, if I understand it correctly, to provide users of the backend components with a URL (serverName) that is unique. Not for eCommerce purposes. For eCommerce, amongst other reasons, the entity 'WebSite' was constructed. > Proposal: URL-Generation Changes > -------------------------------- > > Key: OFBIZ-5312 > URL: https://issues.apache.org/jira/browse/OFBIZ-5312 > Project: OFBiz > Issue Type: New Feature > Components: specialpurpose/ecommerce > Affects Versions: SVN trunk > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Priority: Minor > Labels: changes, ecommerce, friendly, seo, url > Fix For: SVN trunk > > Attachments: OFBIZ-5312 - ofbiz-ecommerce-seo.patch, OFBIZ-5312 - > ofbiz-ecommerce-seo.patch > > > [This was proposed by Paul Piper in Nabble 7 months > ago|http://ofbiz.135035.n4.nabble.com/Proposal-URL-Generation-Changes-td4639289.html]. > Here is quoted Paul's proposal > {quote} > Hey Everyone, > over at ilscipio (www.ilscipio.com) we developed a set of functional OFBiz > changes that we believe the entire community could benefit from. The changes > have been implemented in parts in Syracus (www.syracus.net) for a while now, > but we figured that some of which are too crucial for ofbiz' success in the > long run, so we are considering the contribution (as we did with the SOLR > component). > As you are probably aware, OFBiz has a pretty uncommon way of generating > URLs. Most of this has to do with the fact that OFBiz uses a servlet > (ControlServlet) to handle all requests. The servlet is mounted at /control, > so that it won't interfere with other servlets. Though functionally valid, > this has the sideeffect that all urls are actually created on /control, which > is neither pretty, nor good by any measures of SEO. It also means that a few > 302 redirects are necessary to forward the user from / to /control/main. It > also makes requests more complicated, since many forwards are necessary > whenever somebody wants to move away from this implementation. > Since this is hurtful to many of the implementers, I wanted to discuss > whether or not you guys would be interested in the changes we have made. The > functional changes contain: > * Removal of /control out of all the urls > * SEO-friendly URLS > * Configurable product/category and other URLs > * Frontpage mapping from /main to / > It was tested on our end and contains all necessary improvements (Transforms, > Sample Configuration, Servlets & Filters) for it to be applicable. > If interested, I would create a new JIRA ticket for this and after a few > minor internal discussions, we will gladly provide the rest of you with it. > Regards, > Paul > {quote} > There is even a patch, mostly done by Jinghai Shi, that I attach here. Even > if it has been already used in [Syracus|http://syracus.net/] since early this > year, some help would be needed to test it thoroughly in OFBiz. > Then we should discuss if it's the way to go. I believe it is. Who needs a > /control/ or /main by default in ecommerce urls? Would you not prefer > http://localhost:8080/ecommerce/ over > http://localhost:8080/ecommerce/control/main ? -- This message was sent by Atlassian JIRA (v6.1#6144)