[ 
https://issues.apache.org/jira/browse/OFBIZ-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reopened OFBIZ-4757:
------------------------------------


r1308301 was reverted at 
[r1309337|http://svn.apache.org/viewvc?view=revision&revision=1309337]. So this 
had no influence and should not have closed this issue which still exists today.

Erwan said then (2012-03-26) it worked in trunk (see attached 
log.ofbiz.cobertura) and R11.04. For further analysis, I noticed these lines at 
the bottom of the log:
{code}
     [java] Cobertura: Loaded information on 2264 classes.
     [java] Cobertura: Saved information on 2264 classes.
     [java] Java Result: 99
{code}
I guess (I never used the cobertura feature) those lines were related with 
cobertura-base.dat and cobertura-components.dat files creation.

In trunk an error was introduced with OFBIZ-3651 and 
[r1230444|http://svn.apache.org/viewvc?view=revision&revision=1230444]. This 
was reported byt OFBIZ-4783 and [this 
thread|http://markmail.org/message/bx2hkzrjud6rb4bk] explains it. So it was 
actually fixed with 
[r1341021|http://svn.apache.org/viewvc?view=revision&revision=1341021] and 
[r1341086|http://svn.apache.org/viewvc?view=revision&revision=1341086]. At 
least the line 
{code}
[java] java.lang.ClassNotFoundException: 
org.ofbiz.base.config.CoberturaInstrumenter 
{code}
does not appear currently either in R11.04 nor trunk. So I believe OFBIZ-4783 
can be closed.

Though I tried Pierre's trick about removing lines in base/build.xml, now the 
Cobertura lines above don't appear either in R11.04 when running run-tests, 
{code}
     [java] 2013-10-21 19:51:34,250 (Thread-0) [  
ServiceDispatcher.java:857:INFO ] Shutting down the service engine...
     [java] Java Result: 99
{code}
nor in trunk
{code}
    [java] 2013-10-21 23:31:12,593 (Thread-0) [    
ContainerLoader.java:268:INFO ] Stopped container component-container
    [java] Java Result: 99
{code} 

As a side note, I had also to remove the antcall target="clean-downloads" from 
clean-all at 
[r1201110|http://svn.apache.org/viewvc?view=revision&revision=1201110]

After spending some times on all this, I'm wondering now if the best solution 
is not to get rid of Cobertura in favor of Jacoco as Pierre Smits proposed at 
OFBIZ-4773. It makese sense when you read 
* http://jira.codehaus.org/browse/SONAR-3536, 
* http://docs.codehaus.org/display/SONAR/Release+3.4+Upgrade+Notes 
* and https://en.wikipedia.org/wiki/Java_Code_Coverage_Tools. 

We don't use Maven so seem not concerned by 
* 
http://sonarqube.15.x6.nabble.com/Questions-about-JaCoCo-vs-Cobertura-exclusion-coverage-capabilities-td3223823.html
 
* nor 
https://mail-archives.apache.org/mod_mbox/commons-dev/201305.mbox/%3ccaogo0vaufemp5wd0fpq_3fphvyh0z+q6vwobs2oqv4g5xk6...@mail.gmail.com%3E
 (tough last raises some concerns)

This would have the double advantage of 
* closing pending issues related to Cobertura which BTW does not support Java 7 
and especially Java 8 "soon" coming
* Follow the SonarQuBe flow where Jacoco is default

> Cobertura targets fail
> ----------------------
>
>                 Key: OFBIZ-4757
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4757
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release 09.04.01, Release 10.04, Release Branch 11.04, 
> SVN trunk
>         Environment: UBUNTU 10.04 LTS, Mac OS X 10.6.8
>            Reporter: Pierre Smits
>            Assignee: Erwan de FERRIERES
>             Fix For: Release Branch 11.04, SVN trunk
>
>         Attachments: log.ofbiz.cobertura
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When running ./ant cobertura-report or ./ant cobertura-report-xml following 
> error is generated:
> Buildfile: /Users/s0001/Documents/workspace/ofbiz-trunk/build.xml
> cobertura-report-xml:
>    [delete] Deleting directory 
> /Users/s0001/Documents/workspace/ofbiz-trunk/runtime/logs/cobertura-report
>     [mkdir] Created dir: 
> /Users/s0001/Documents/workspace/ofbiz-trunk/runtime/logs/cobertura-report
> [cobertura-merge] Cobertura 1.9.4.1 - GNU GPL License (NO WARRANTY) - See 
> COPYRIGHT file
> [cobertura-merge] Error: No files were specified for merging.
> BUILD FAILED
> /Users/s0001/Documents/workspace/ofbiz-trunk/build.xml:1003: Error running 
> reports. See messages above.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to