[ 
https://issues.apache.org/jira/browse/OFBIZ-5384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-5384.
----------------------------------

    Resolution: Not A Problem
      Assignee: Jacques Le Roux

Leon,

To be fair, I also did not know about the Invitation feature. While reviewing I 
discovered it. You get to it from Party/Invitation menu.

For r1178353 it's quite possible it was not tested thoroughly (it also misses 
in the commit comment a clear explanation about what invitation is and how it 
works). But the bug I fixed in r1538096 was introduced by me for OFBIZ-3883. I 
then forgot to change from setShippingContactMechId to 
setAllShippingContactMechId in ftl and groovy files, which is quite bad when 
you think about it. Fortunately all is under control now :).

The ecommerce frontend has been neglected these last years. On the other hands 
my few recent fixes are minors (though not always easy to fix), most work (but 
the login from r1534264, Adrian said he will look at it soon).

I close as not a pb

> Not need to set shipping info in CheckInits.groovy
> --------------------------------------------------
>
>                 Key: OFBIZ-5384
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5384
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-5384.patch
>
>
> In the tail of CheckInits.groovy, there're some code to set shipping info of 
> assigned party into shopping cart. But it's not necessary, and the code is 
> buggy (1. check Person only 2. no 
> shoppingCart.setShippingContactMechId(String) method defined).
> So I remove these codes from CheckInits.groovy. Pls see attached patch.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to