[
https://issues.apache.org/jira/browse/OFBIZ-5400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13847617#comment-13847617
]
Christian Carlow commented on OFBIZ-5400:
-----------------------------------------
Heads up to the committer, I'm working on resolving a bug in the patch I
provided. The sales tax adjustments are incorrectly applied for each ship
group qty whereas before they were only applied once for the whole order item
quantity.
Also, a bug was discovered if the ship group functionality in this patch does
not exist.
To reproduce:
1. Create an order for DemoCustCompany
2. Add GZ-1000 with a quantity of 3 to the cart
3. Click "Finalize Order"
4. Add 2 more ship groups and click "Continue"
5. Assign a quantity of 1 to each ship group
6. Click "Order Items"
7. Check mark the GZ-1000 order item row and click "Recalculate Order"
8. Finalize the order and notice that the ship group quantities do not add up
to the order item quantity.
The ship group quantities do not add up to the order item quantity because when
updating order items after they have been assigned to ship groups, it takes the
order item quantity and applies it to the first ship group. So once step 7
occurs, the first ship group quantity gets changed from 1 (set in step 5) to 3,
leaving the ship group quantity sum to be 3+1+1=5 even thought the order item
total is 3.
where the ship group quantities specified do not add up to the order item total
quantity when updating order items after
> Improve order application to better handle complex ship groups
> --------------------------------------------------------------
>
> Key: OFBIZ-5400
> URL: https://issues.apache.org/jira/browse/OFBIZ-5400
> Project: OFBiz
> Issue Type: Improvement
> Affects Versions: SVN trunk
> Reporter: Christian Carlow
> Attachments: OFBIZ-5400.patch, OFBIZ-5400_0.patch
>
>
> The order entry form should be improved to better handle orders with complex
> shipments. Its difficult to use the current order entry forms for entering
> ship group information when dealing with 10 or more ship groups with
> different destinations, carriers, shipment methods, and dates.
> Improvements should include:
> 1. Allow ship groups to be edited even if the cart is empty
> 2. Allow the address, carrier shipment method, and shipping dates to be
> specified on a single page instead of relying on three separate pages
> 3. Allow items to be assigned to ship groups when creating or updating. The
> order items page of existing orders already provides this functionality by
> allowing quantities to be specified for each ship group for each order item.
> Similarly, ship groups should be listed with quantity fields for each item
> when more than one ship group exists so that items can be assigned to ship
> groups directly when added or updated.
> 4. Allow ability to assign items directly to ship groups to the form on the
> order edit page that allows appending of items to existing orders. Existing
> items already have this ability so it should be expanded to this form as well.
> 5. Allow ability to reorder the ship group sequence. Having the ability to
> control the sequence of the list of ship group quantity fields would be very
> useful if the other functionality is implemented. This would allow for
> example, a ship group with a date that falls between existing ship group
> dates to be resequenced to fall between those respective ship group dates
> when listed for order items.
> 6. Allow ship groups to be deleted/removed. Adding a fromDate and thruDate
> to the OrderItemShipGroup entity could provide this functionality. Logic
> would have to check to ensure that no order items have been assigned before
> removing the ship group.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
