[
https://issues.apache.org/jira/browse/OFBIZ-5312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942873#comment-13942873
]
Paul Piper commented on OFBIZ-5312:
-----------------------------------
[~jacques.le.roux]:
I noticed a few minor things we should improve upon in a later release:
1)
{code}
<char-filters>
<char-filter>
<character-pattern>\u00fc</character-pattern>
<replacement>ue</replacement>
</char-filter>
<char-filter>
<character-pattern>\u00e4</character-pattern>
<replacement>ae</replacement>
</char-filter>
<char-filter>
<character-pattern>\u00f6</character-pattern>
<replacement>oe</replacement>
</char-filter>
<char-filter>
<character-pattern>\u00df</character-pattern>
<replacement>ss</replacement>
</char-filter>
<char-filter>
<character-pattern>\\+</character-pattern>
<replacement>und</replacement>
</char-filter>
<char-filter>
<character-pattern>\u0026</character-pattern>
<replacement>und</replacement>
</char-filter>
<char-filter>
<character-pattern>รจ</character-pattern>
<replacement>e</replacement>
</char-filter>
{code}
This is currently a "german" interpretation, as the ampersand character (&) is
being replaced by "und" in the urls. It also misses other diacritics entirely.
I think we can actually get rid of this and rather use the Java Normalizer for
this in the java code. It will do the same thing and handles
internationalisation nicely:
{code}
string = Normalizer.normalize(string, Normalizer.Form.NFD);
string = string.replaceAll("[^\\p{ASCII}]", "");
{code}
2) Currently the SeoConfig.xml is located in /application/product/config - i
would argue that we should move this to either /framework/common/config or
/specialpurpose/ecommerce/config as it affects more aspects than the
productUrls and is also rather ecommerce specific at the current state.
3) You asked me about "partial matches":
In general the ids are what's important and not the remainder of the string, so
you can add more or less text in front of the ids and it should still work. It
is a moot point, since they are autogenerated the same way throughout the
entire application, but we may want to redirecting a user if the request-url
doesn't match the final, generated url. All we'd have to do is add a check in
the filter, generate the url again based on the id, compare both and redirect
if they don't match.
> Proposal: URL-Generation Changes (mostly for SEO reasons but not only)
> ----------------------------------------------------------------------
>
> Key: OFBIZ-5312
> URL: https://issues.apache.org/jira/browse/OFBIZ-5312
> Project: OFBiz
> Issue Type: New Feature
> Components: specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
> Labels: changes, ecommerce, friendly, seo, url
> Fix For: SVN trunk
>
> Attachments: OFBIZ-5312 - ofbiz-ecommerce-seo.patch, OFBIZ-5312 -
> ofbiz-ecommerce-seo.patch, OFBIZ-5312 - ofbiz-ecommerce-seo.patch, OFBIZ-5312
> - ofbiz-ecommerce-seo.patch, OFBIZ-5312 - ofbiz-ecommerce-seo.patch,
> OFBIZ-5312 - ofbiz-ecommerce-seo.patch, OFBIZ-5312 -
> ofbiz-ecommerce-seo.patch, OFBIZ-5312 - ofbiz-ecommerce-seo.patch, OFBIZ-5312
> - ofbiz-ecommerce-seo.patch, OFBIZ-5312 - ofbiz-ecommerce-seo.patch,
> OFBIZ-5312 - ofbiz-ecommerce-seo.patch, OFBIZ-5312 -
> ofbiz-ecommerce-seo.patch, OFBiz-5312-product-ecommerce-seo-20131031.patch,
> OFBiz-5312-product-ecommerce-seo-for-seo-branch.patch,
> OFBiz-5312-product-ecommerce-seo.patch, SeoContextFilter.java.patch
>
>
> [This was proposed by Paul Piper in Nabble 7 months
> ago|http://ofbiz.135035.n4.nabble.com/Proposal-URL-Generation-Changes-td4639289.html].
> Here is quoted Paul's proposal
> {quote}
> Hey Everyone,
> over at ilscipio (www.ilscipio.com) we developed a set of functional OFBiz
> changes that we believe the entire community could benefit from. The changes
> have been implemented in parts in Syracus (www.syracus.net) for a while now,
> but we figured that some of which are too crucial for ofbiz' success in the
> long run, so we are considering the contribution (as we did with the SOLR
> component).
> As you are probably aware, OFBiz has a pretty uncommon way of generating
> URLs. Most of this has to do with the fact that OFBiz uses a servlet
> (ControlServlet) to handle all requests. The servlet is mounted at /control,
> so that it won't interfere with other servlets. Though functionally valid,
> this has the sideeffect that all urls are actually created on /control, which
> is neither pretty, nor good by any measures of SEO. It also means that a few
> 302 redirects are necessary to forward the user from / to /control/main. It
> also makes requests more complicated, since many forwards are necessary
> whenever somebody wants to move away from this implementation.
> Since this is hurtful to many of the implementers, I wanted to discuss
> whether or not you guys would be interested in the changes we have made. The
> functional changes contain:
> * Removal of /control out of all the urls
> * SEO-friendly URLS
> * Configurable product/category and other URLs
> * Frontpage mapping from /main to /
> It was tested on our end and contains all necessary improvements (Transforms,
> Sample Configuration, Servlets & Filters) for it to be applicable.
> If interested, I would create a new JIRA ticket for this and after a few
> minor internal discussions, we will gladly provide the rest of you with it.
> Regards,
> Paul
> {quote}
> There is even a patch, mostly done by Jinghai Shi, that I attach here. Even
> if it has been already used in [Syracus|http://syracus.net/] since early this
> year, some help would be needed to test it thoroughly in OFBiz.
> Then we should discuss if it's the way to go. I believe it is. Who needs a
> /control/ or /main by default in ecommerce urls? Would you not prefer
> http://localhost:8080/ecommerce/ over
> http://localhost:8080/ecommerce/control/main ?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
