Christian, thank you for digging into this issue. I would actually prefer to cancel this vote, and prepare a new set of release files and then start again.
Jacopo On Mar 23, 2014, at 3:10 AM, Christian Geisert <christian.geis...@isu-gmbh.de> wrote: > Am 23.03.2014 00:09, schrieb Christian Geisert: >> Am 22.03.2014 20:48, schrieb Jacques Le Roux: >>> +0 (miss below ;) >>> >>> MD5 OK >>> >>> Failure in run tests in Windows 7 >>> >>> production-run-tests.testProductionRunDateChange Failure Assertion >>> failed: ([taskTimeDifference=-3600000.0] equals 0.0 as Double OR >>> [taskTimeDifference=-3600000.0] equals 1.0 as Double OR >>> [taskTimeDifference=-3600000.0] equals -1.0 as Double OR ) >>> >>> junit.framework.AssertionFailedError: Assertion failed: >>> ([taskTimeDifference=-3600000.0] equals 0.0 as Double OR >>> [taskTimeDifference=-3600000.0] equals 1.0 as Double OR >>> [taskTimeDifference=-3600000.0] equals -1.0 as Double OR ) >>> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100) >>> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:147) >>> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:238) >>> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:340) >>> at org.ofbiz.base.start.Start.start(Start.java:382) >>> at org.ofbiz.base.start.Start.main(Start.java:122) >>> >>> Same failure in Ubuntu 13.10 running in virtualbox on Windows7 >> >> I can confirm this failure (Java 1.6.0_38 under Ubuntu) - changing >> Locale to en doesn't help. Same problem with trunk. >> >> I'll try to have a closer look later (insert $RANT about Minilang) > > Wow, that was fun ;-) > > There's actually a hint inside the code: > <!-- a difference of +1 or -1 is accepted because it could be caused by > DST change happening in one of the two time periods --> > > And there is a DST next week here in Germany... > > But the difference is calculated in millisecs and not in hours so the > allowed difference should be +/- 60 * 60 * 1000 ms > > I don't think this is a showstopper for the release (the actual > calculating is right, just a bug in the test - and it will last for just > one week...) > > So +1 for the release > > Christian >
