Re: svn commit: r1589562 - /ofbiz/trunk/framework/start/src/org/ofbiz/base/start/Config.java

[Hans Bakker]

up to you Jacques, but changing the port number in start.properties has 
no effect without this change.

Regards,Hans
On 24/04/14 15:18, Jacques Le Roux wrote:
Hi Hans,

Did you cross this issue using the portoffset parameters?

This sounds weird to me because you should get there only in this 
case. And when using a positive non zero parameter (a zero parameter 
does not make sense), your change breaks the portoffset code

I could use
    adminPort = adminPort >= 0 ? adminPort : 10523; // This is 
necessary because the ASF machines don't allow ports 1 to 3, see 
INFRA-6790
But I prefer to clarify the issue you crossed before

Jacques

Le 24/04/2014 05:57, hans...@apache.org a écrit :
Author: hansbak
Date: Thu Apr 24 03:57:06 2014
New Revision: 1589562

URL: http://svn.apache.org/r1589562
Log:
adminport in start.properties was ignored. fixed

Modified:
ofbiz/trunk/framework/start/src/org/ofbiz/base/start/Config.java

Modified: 
ofbiz/trunk/framework/start/src/org/ofbiz/base/start/Config.java
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/framework/start/src/org/ofbiz/base/start/Config.java?rev=1589562&r1=1589561&r2=1589562&view=diff
============================================================================== 

--- ofbiz/trunk/framework/start/src/org/ofbiz/base/start/Config.java 
(original)
+++ ofbiz/trunk/framework/start/src/org/ofbiz/base/start/Config.java 
Thu Apr 24 03:57:06 2014
@@ -353,7 +353,7 @@ public class Config {
              if (args.length > 0) {
                  for (String arg : args) {
                      if (arg.toLowerCase().contains("portoffset=") 
&& !arg.toLowerCase().contains("${portoffset}")) {
-                        adminPort = adminPort != 0 ? adminPort : 
10523; // This is necessary because the ASF machines don't allow 
ports 1 to 3, see  INFRA-6790
+                        adminPort = adminPort == 0 ? adminPort : 
10523; // This is necessary because the ASF machines don't allow 
ports 1 to 3, see  INFRA-6790
                          adminPort += 
Integer.parseInt(arg.split("=")[1]);
                      }
                  }