[ 
https://issues.apache.org/jira/browse/OFBIZ-5615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13996137#comment-13996137
 ] 

Paul Foxworthy commented on OFBIZ-5615:
---------------------------------------

Committed to trunk in rev 1594141. I don't think this one is worth backporting.

> Clean up compiler warning in InvoiceServices
> --------------------------------------------
>
>                 Key: OFBIZ-5615
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5615
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Paul Foxworthy
>            Assignee: Paul Foxworthy
>            Priority: Minor
>              Labels: invoice
>         Attachments: OFBIZ-5615_InvoiceServicesNullPointerWarning.patch
>
>
> In createInvoicesFromShipment, the variable invoicePerShipment may hold a 
> null if it happens that the invoicePerShipment attribute in the OrderHeader 
> is null. The situation is very unlikely, because the createOrder service sets 
> invoicePerShipment provided there is a valid configuration setting 
> create.invoice.per.shipment .
> Still, there is a warning from some compilers and static code analysis tools 
> regarding a possible null value. The patch eliminates the warning.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to