[ 
https://issues.apache.org/jira/browse/OFBIZ-5578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14009849#comment-14009849
 ] 

Jacques Le Roux commented on OFBIZ-5578:
----------------------------------------

Hi Darrel,

Your patch  works well but if you don't let setPackedOnly empty *AND* one 
ordered product miss inventory

I have applied your patch and tried to run the quickShipEntireOrder service 
passing "Yes" as setPackedOnly value. I got the error attached as 
"OFBIZ-5578-Quick Ship Entire Order Never Shipping.log" file. Unfortunately the 
error messages are in French but I guess you can easily reproduce in your own 
OFBiz instance. I used trunk with a fresh load-demo and ordered 1 GZ-1000 and 5 
GZ-1001 twice (2 successive same orders) with the second quickShipEntireOrder 
service passing "Yes" as setPackedOnly fails.

Did you not encouter such issues. If yes did you find a fix already?



> Quick Ship Entire Order Never Shipping
> --------------------------------------
>
>                 Key: OFBIZ-5578
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5578
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk, Release Branch 12.04
>            Reporter: Darrell Donati
>            Assignee: Jacopo Cappellato
>             Fix For: SVN trunk, Release Branch 12.04
>
>         Attachments: OFBIZ-5578-Quick Ship Entire Order Never Shipping.log, 
> ShipmentServices.xml.patch
>
>
> The quickShipEntireOrder in ShipmentServices.xml takes in an optional field 
> called "setPackedOnly". This check for setPackedOnly was added to 
> 'createShipmentForFacilityAndShipGroup' in r1139346. QuickShipEntireOrder 
> also calls the 'createShipmentForFacilityAndShipGroup' simple method, but 
> setPackedOnly is never set in the context before making the call, meaning 
> that setPackedOnly is always empty when it's checked in the method. 
> Additionally, the check on setPackedOnly is written such that if 
> setPackedOnly is NOT empty, the status is taken to SHIPPED. Instead, it makes 
> sense for it to be taken to SHIPPED status when setPackedOnly IS empty (see 
> 'setShipmentStatusPackedAndShipped' Line 1719).
> See my original thread on the ML here: 
> http://ofbiz.135035.n4.nabble.com/Quick-Ship-Order-Status-Service-td4648696.html



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to