[ https://issues.apache.org/jira/browse/OFBIZ-5331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14043067#comment-14043067 ]
Adam Heath commented on OFBIZ-5331: ----------------------------------- This is next on my list. Nice change, but not applying directly. The same kind of optimization for short-circuit could be applied to the other methods. But, then it should be done even smarter, with a helper method. But, before doing such a change, api test cases should be added, to ensure full coverage of all branches before changing. Stay tuned. > Change EntityComparisonOperator to use compareTo() > -------------------------------------------------- > > Key: OFBIZ-5331 > URL: https://issues.apache.org/jira/browse/OFBIZ-5331 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Joe Eckard > Priority: Trivial > Attachments: patch.txt > > > The methods compareEqual() and compareNotEqual() both use equals() instead of > compareTo() which can be problematic when used to compare BigDecimal objects. -- This message was sent by Atlassian JIRA (v6.2#6252)