[
https://issues.apache.org/jira/browse/OFBIZ-1026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14043747#comment-14043747
]
Adam Heath commented on OFBIZ-1026:
-----------------------------------
Interesting idea, very wrong implementation. This should reuse the other parts
of the entity engine, namely, EntityConditionValue, EntityCondition,
ModelEntity, etc, to provide this feature. Directly embedding a string, while
very hackish, could even be a security issue in some scenarios.
Additionally, this should not be done as a comparison operator; It throws away
lhs, and would lead to extremely weird calling code. It should extend
EntityCondition(as that is the raw atom), similar to how
EntityConditionSubSelect is done.
> EntityOperator IN_SUBQUERY enhancement
> --------------------------------------
>
> Key: OFBIZ-1026
> URL: https://issues.apache.org/jira/browse/OFBIZ-1026
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Environment: Win XP
> Reporter: Karl Eilebrecht
> Assignee: Adam Heath
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: patch9664.patch
>
>
> This issue is part of Key-Work Ofbiz Contribution Proposal.
> http://docs.ofbiz.org/display/OFBIZ/Key-Work+Ofbiz+Contribution+Proposal
> Based on Release: 540035
> Includes: -
> Required: -
> Recommended: -
> Classes: EntityOperator.java
> Description: Adds the IN_SUBQUERY operator. This may be useful for
> exceptional cases to realize complex find conditions.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
