[ 
https://issues.apache.org/jira/browse/OFBIZ-5534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14044864#comment-14044864
 ] 

Adam Heath commented on OFBIZ-5534:
-----------------------------------

Keeping the list of entities from being polluted is the same as keeping the 
findOne cache clean as well.  The code inside the first transaction may update 
a value, then call findList(), and the results get cached, and now another 
thread will see it.

Trust me, the place for these changes is in the Cache object.  I've already 
been playing around with XAResource and Synchronization.  And I already have 
the cache mutations being delayed and replayed at the end of the transaction.  
I just don't allow for any cache reads while inside the transaction, which does 
cause a slowdown.

> Dirty reads from entity cache
> -----------------------------
>
>                 Key: OFBIZ-5534
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5534
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 11.04, SVN trunk, Release Branch 12.04, 
> Release Branch 13.07
>            Reporter: Jacopo Cappellato
>            Assignee: Adam Heath
>         Attachments: unittest-dirtyreadsfromcache.patch
>
>
> Even if database transaction isolation level is set to "ReadCommitted", a 
> transaction can get uncommitted records from the entity cache, under certain 
> circumstances.
> Here is a test case:
> 1) transaction T1 creates a record
> 2) T1 calls findOne to retrieve it: the read will be successful (because T1 
> can read data generated in T1 even if not committed) and the record will be 
> added to the cache
> 3) T1 calls another service with requireNewTransaction set to true: this will 
> run the second service in a new transaction T2
> 4) T2 calls findOne to retrieve the record created by T1: if useCache is set 
> to false it should fail; if useCache is set to true it will succeed (getting 
> the record from cache, even if the data is not committed to the db)
> The result in #4 is wrong because T2 should not see the uncommitted record
> We should never add uncommitted records to the entity cache.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to