[
https://issues.apache.org/jira/browse/OFBIZ-5565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14047811#comment-14047811
]
Adam Heath commented on OFBIZ-5565:
-----------------------------------
If the code is in order, then the test case should be in order. If the code is
in accounting, then place the test case there. Since this method exists in
order, the test case was placed there. And, the test case I committed tests
*just* that method, not any high-level stuff that might use it. IE, it doesn't
test the high-level stuff in accounting.
> FinAccountHelper.getFinAccountFromCode() no longer returns financial account
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-5565
> URL: https://issues.apache.org/jira/browse/OFBIZ-5565
> Project: OFBiz
> Issue Type: Bug
> Components: accounting, order
> Affects Versions: SVN trunk, Release Branch 13.07
> Environment: Primarily tested on Ubuntu, but affects all OS.
> Reporter: Vyom Jain
> Assignee: Adam Heath
> Fix For: SVN trunk
>
> Attachments: OFBIZ-5565.patch
>
>
> FinAccountHelper.getFinAccountFromCode() in trunk as well as in some of the
> released versions is no longer able to fetch the Financial Account ID.
> So all features dependent on this method would no longer work (an example
> being paying by gift card during order entry process).
> Per my research, this stopped working method post some changes related to how
> data is encrypted (two strings will not have similar encrypted string).
> I had tried this on a fresh SVN trunk checkout with absolutely no changes
> (had been using Derby database).
> Furthermore, the ant target gen-kek references old jars and that needs fixing
> as well.
> Steps to test -
> 1. Create a new Financial account (gift certificate) for DemoCustomer -
> https://demo-trunk.ofbiz.apache.org/accounting/control/FindFinAccount?ownerPartyId=DemoCustomer
> and deposit some funds into it.
> 2. Create an order for DemoCustomer from the Order Manager application.
> 3. Use "Quick Finalize Order", try paying by the gift card created in step #1.
> Observations -
> 1. Returns an error "This gift card does not exist"
> Related User ML post -
> http://mail-archives.apache.org/mod_mbox/ofbiz-user/201403.mbox/%3CCAKuEJqZChmJaWF=rzn1z-vudnzbnsdulj4j6pxjtd5ijynu...@mail.gmail.com%3E
> Thanks.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
