I may be wrong but I think that according to this:

https://ant.apache.org/manual/Tasks/javacc.html
https://ant.apache.org/manual/Tasks/jjtree.html

we do not need to explicitly define the following two taskdef:

 <taskdef name="javacc" 
classname="org.apache.tools.ant.taskdefs.optional.javacc.JavaCC" 
classpath="${ofbiz.home.dir}/framework/base/lib/ant/ant-nodeps-1.7.1.jar"/>
 <taskdef name="jjtree" 
classname="org.apache.tools.ant.taskdefs.optional.javacc.JJTree" 
classpath="${ofbiz.home.dir}/framework/base/lib/ant/ant-nodeps-1.7.1.jar"/>

because they are now available in the core ant distro.

Jacopo


On Jul 20, 2014, at 1:19 PM, Jacques Le Roux <jacques.le.r...@les7arts.com> 
wrote:

> For now see http://svn.apache.org/viewvc?view=revision&revision=r1612053
> W/o answers from Adam, I think we can also remove in macros.xml
> 
> Le 20/07/2014 12:26, Jacopo Cappellato a écrit :
>> According to this:
>> 
>> http://archive.apache.org/dist/ant/RELEASE-NOTES-apache-ant-1.8.2.html
>> 
>> and specifically to:
>> 
>> "* Removed ant-nodeps.jar; it is now merged into ant.jar."
>> 
>> and considering that we are running ant 1.9, I don't think we ahould keep 
>> any reference to ant-nodeps.
>> 
>> Jacopo
>> 
>> 
>> 
>> On Jul 20, 2014, at 10:14 AM, Jacques Le Roux <jacques.le.r...@les7arts.com> 
>> wrote:
>> 
>>> There are still references to ant-nodeps though it's not there anymore, 
>>> what should be the status? (I was tempted to remove references...)
>>> 
>>> Jacques
>>> 
>>> Le 24/06/2014 22:30, doo...@apache.org a écrit :
>>>> Author: doogie
>>>> Date: Tue Jun 24 20:30:26 2014
>>>> New Revision: 1605178
>>>> 
>>>> URL: http://svn.apache.org/r1605178
>>>> Log:
>>>> Revert "Fix Eclipse classpath file."
>>>> 
>>>> This reverts commit 823b2d691f2d688153c13b7d87aea35a17f23ef0.
>>>> 
>>>> Modified:
>>>>     ofbiz/trunk/.classpath
>>>> 
>>>> Modified: ofbiz/trunk/.classpath
>>>> URL: 
>>>> http://svn.apache.org/viewvc/ofbiz/trunk/.classpath?rev=1605178&r1=1605177&r2=1605178&view=diff
>>>> ==============================================================================
>>>> --- ofbiz/trunk/.classpath (original)
>>>> +++ ofbiz/trunk/.classpath Tue Jun 24 20:30:26 2014
>>>> @@ -10,10 +10,11 @@
>>>>      <classpathentry kind="lib" 
>>>> path="applications/content/lib/tika-parsers-1.0.jar"/>
>>>>      <classpathentry kind="lib" 
>>>> path="applications/product/lib/watermarker-0.0.4.jar"/>
>>>>      <classpathentry kind="lib" 
>>>> path="applications/product/lib/dozer-4.2.1.jar"/>
>>>> -    <classpathentry kind="lib" path="lib/ant/ant-1.9.0-ant.jar"/>
>>>> -    <classpathentry kind="lib" path="lib/ant/ant-1.9.0-ant-junit.jar"/>
>>>> -    <classpathentry kind="lib" path="lib/ant/ant-1.9.0-ant-launcher.jar"/>
>>>> -    <classpathentry kind="lib" 
>>>> path="lib/ant/ant-1.9.0-ant-apache-bsf.jar"/>
>>>> +    <classpathentry kind="lib" 
>>>> path="framework/base/lib/ant-1.9.0-ant.jar"/>
>>>> +    <classpathentry kind="lib" 
>>>> path="framework/base/lib/ant-1.9.0-ant-junit.jar"/>
>>>> +    <classpathentry kind="lib" 
>>>> path="framework/base/lib/ant-1.9.0-ant-launcher.jar"/>
>>>> +    <classpathentry kind="lib" 
>>>> path="framework/base/lib/ant/ant-1.9.0-ant-apache-bsf.jar"/>
>>>> +    <classpathentry kind="lib" 
>>>> path="framework/base/lib/ant/ant-nodeps-1.8.1.jar"/>
>>>>      <classpathentry kind="lib" 
>>>> path="framework/base/lib/antisamy-bin.1.2.jar"/>
>>>>      <classpathentry kind="lib" 
>>>> path="framework/base/lib/avalon-framework-4.2.0.jar"/>
>>>>      <classpathentry kind="lib" 
>>>> path="framework/base/lib/avalon-util-exception-1.0.0.jar"/>
>>>> 
>>>> 
>>>> 
>> 
>> 

Reply via email to