I think that the current position is ok and the prefixes should be enough to 
warn the committers.
The full explanation is here: 
http://tomcat.apache.org/tomcat-7.0-doc/logging.html#Using_Log4j

Jacopo

On Aug 8, 2014, at 11:06 AM, Jacques Le Roux <jacques.le.r...@les7arts.com> 
wrote:

> Ha OK, I asked for it in another email because I understood the opposite in 
> you commit comment
> Maybe we should rather place them in another extras sub-folder with a README 
> to make things more clear and prevent this kind of error in the future?
> 
> Sorry for that :/
> 
> Jacques
> 
> Le 08/08/2014 09:47, Jacopo Cappellato a écrit :
>> Jacques,
>> 
>> unfortunately I just discovered (after several hours of testing) that you 
>> did the upgrade incorrectly! This is a pain and I will have to cancel the 
>> vote for the 12.04.04 release.
>> After the upgrade the tomcat logs are no more processed by log4j; it took me 
>> a long time to figure out what the problem: all the jars you have updated 
>> seemed ok to me, including the two for juli: you added the prefix "extras" 
>> to keep track of the source of the file, which is good... apart from the 
>> fact that you didn't copy the one from the Tomcat Extras ditro and you have 
>> just used the one from the standard distro... ouch...
>> 
>> Jacopo
>> 
>> On Aug 3, 2014, at 7:27 AM, Jacopo Cappellato 
>> <jacopo.cappell...@hotwaxmedia.com> wrote:
>> 
>>> Jacques,
>>> 
>>> thank you for the upgrade and for backporting it to 12.04.
>>> I am now tempted to cancel the release vote and restart it to include the 
>>> newer version, what do you think?
>>> 
>>> Jacopo
>>> 
>>> On Aug 2, 2014, at 1:22 PM, jler...@apache.org wrote:
>>> 
>>>> Author: jleroux
>>>> Date: Sat Aug  2 11:22:21 2014
>>>> New Revision: 1615299
>>>> 
>>>> URL: http://svn.apache.org/r1615299
>>>> Log:
>>>> "Applied fix from trunk for revision: 1615296"
>>>> ------------------------------------------------------------------------
>>>> r1615296 | jleroux | 2014-08-02 13:18:26 +0200 (sam. 02 août 2014) | 3 
>>>> lignes
>>>> 
>>>> Update Tomcat from 7.0.54 to 7.0.55
>>>> No changes in framework\base\lib\j2eespecs
>>>> 
>>>> ------------------------------------------------------------------------
>>>> 
>> 
>> 

Reply via email to