[ 
https://issues.apache.org/jira/browse/OFBIZ-5741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14117162#comment-14117162
 ] 

Jacques Le Roux commented on OFBIZ-5741:
----------------------------------------

Hi Nicolas, I was just wondering about labels like 
ProductCatalogDeletePermissionError. I saw you added 
checkProductStoreRelatedPermission but I see only 
ProductCatalogCreatePermissionError there. So it's done through 
resource-description="deleteProductStoreCatalog" but then where is the label?

For resource-description I read in services.xsd
bq. This will be used in error messages, et cetera. If not specified will 
default to a service name.
Do we all agree it's enough if there is no specific labels? Then if we continue 
this way (ie not yet), should we not remove those labels?

> Convert ProductStore entites CRUD service from simple to entity-auto
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-5741
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5741
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: Trunk
>            Reporter: Nicolas Malin
>            Priority: Trivial
>              Labels: entity-auto, product
>         Attachments: OFBIZ-5741.patch
>
>
> I converted CRUD service to entity-auto for :
>     ProductStoreCatalog
>     ProductStorePaymentSetting
>     ProductStoreEmail
>     ProductStoreVendorPayment
>     ProductStoreShipMeth
>     ProductStoreRole
>     ProductStoreKeywordOvrd
>     ProductStoreSurveyAppl
>     ProductStoreFinActSetting
>     ProductStoreVendorShipment
> I keep to service in mini lang ProductStore.
> I add a new permission service on product store with the same template of 
> produt and productCategory for more homogeneity.
> I run manual test create/update/delete from product store screen with success 
> and I run ./ant clean-all load-demo run-tests without error



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to