Committed with rev. 1624549; unit tests are included. For easy reference of reviewers and to prepare a changelog for future releases I have also created a Jira ticket (now resolved): https://issues.apache.org/jira/browse/OFBIZ-5768
Jacopo On Sep 12, 2014, at 3:09 AM, Hans Bakker <mailingl...@antwebsystems.com> wrote: > Jacopo, > > I am fine with these changes as long as junit tests are provided, i feel > pretty strong about this. Going to continuous deployment is the way to go. > For your information I just wrote a linkedin post about that: > > https://www.linkedin.com/pulse/article/20140909060033-1227556-upgrade-your-erp-system-like-a-phone-app > > I know this is a controversial subject in this mailing list, still very > important going with this rather new development. > > Regards, > Hans > > > On 11/09/14 23:46, Jacopo Cappellato wrote: >> Hi all, >> >> after I spent a good amount of time studying how Java class loaders works >> and are setup in OFBiz I realized that there was room for improving some old >> code and simplify it a lot by removing the old and custom CachedClassLoader >> that is created for each of the OFBiz web applications. >> >> I am pretty confident that this change will work well and that will make the >> framework code that manages classloaders easier to read and maintain, and >> will also be a small step in the direction of making OFBiz easier to deploy >> on external application servers, with no penalties for performance. >> My preference would be to commit the code in the trunk (no API changes or >> other impact for the applications and external configuration) and then let >> you review my work. >> If, on the other hand, you prefer I submit a patch to Jira, I will be happy >> too. >> >> Please let me know. >> >> Jacopo >> >