Hi Nicolas, to keep it simple, we could return a more generic message (common to all entity-auto deletion) and remove the specific ones; I would also remove the associated label (if not used elsewhere). I doubt that, with this approach we will loose much information because the various WorkEffortRequirementFulfillmentDoesNotExists may all be similar; if, in the migration process, you will find some exceptions where the message is very specific and informative, you could leave the service as is for now (but I doubt you will find many of these).
Just my 2 cents Jacopo On Sep 23, 2014, at 12:19 AM, Nicolas Malin <[email protected]> wrote: > Hello all, > > Second pass on the entity-auto engine ;) > I found some service that would be available to entity-auto conversion but a > label is present to return a specific message. > We have some permission error message that will be manage by a permission > service and failure message like this : > <simple-method method-name="deleteWorkRequirementFulfillment" > short-description="Delete a WorkRequirementFulfillment"><!--entity-auto--> > <entity-one entity-name="WorkRequirementFulfillment" > value-field="workRequirementFulfillment"/> > <if-empty field="workRequirementFulfillment"> > <add-error> > <fail-property resource="WorkEffortUiLabels" > property="WorkEffortRequirementFulfillmentDoesNotExists"/> > </add-error> > <check-errors/> > </if-empty> > > What is the best orientation ? Convert all service with specific error > message and extend the entity auto to return a comprehensive message, or > modify nothing ? > On the first case we progess on CRUD homogenization. > On the second case we keep dedicate message for the end user. > > what do you think? >
