[ 
https://issues.apache.org/jira/browse/OFBIZ-5853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14204210#comment-14204210
 ] 

Hans Bakker commented on OFBIZ-5853:
------------------------------------

I am sorry, i have better ways to spend my time, my last comment: revert the 
change you did on createPartyRole for reason it is incompatible with the 
previous version and it is used many times inside OFBiz and in user code.

Hans

> The createPartyRole service does not check a duplicate key.
> -----------------------------------------------------------
>
>                 Key: OFBIZ-5853
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5853
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: Trunk
>            Reporter: Supatthra Nawicha
>            Assignee: Nicolas Malin
>            Priority: Minor
>             Fix For: Trunk
>
>         Attachments: OFBIZ-5853.patch, OFBIZ-5853.patch, 
> ofbizbug_CreatePartyroleService.diff
>
>
> The createPartyRole service is changed from minilang to entity-auto which 
> does not check a duplicate key. It effect to the 
> createPartyRelationshipContactAccount service which call the createPartyRole 
> service without check a duplicate key. And it might effect to other code that 
> call the createPartyRole service as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to