Ha I must add that, using ant clean-all run-install run-tests on Windows 7 tests don't pass here. So, since I'm basically working on Windows, it would need for me to launch Ubuntu in VirtualBox each time I backport on R11 (I won't anymore). That's why I rely on Buildbot, which unfortunately has been quite quirky these last times. Feeling like being the only one to care, I stopped to show as being the only one to harass the infra team about it :/

I must also say I stopped because Gavin told me that the Buildbot resource OFBiz uses are given by Y! and the infra team seems to not have much grip on that. So it's still erratic though better than 1 or 2 months ago...

Jacques

Le 10/11/2014 09:33, Jacques Le Roux a écrit :
Thanks Scott,

Unfortunately we have no tests for that in R11.04 (not sure about the rest) since my last commit (r1623396) passed the tests: http://ci.apache.org/builders/ofbiz-branch11

Reverted at revision: 1637807

Jacques

Le 10/11/2014 05:06, Scott Gray a écrit :
Jacques could you revert this when you get a chance? CountryAddressFormat doesn't exist in 11.04. Another reminder (I've lost count) that changes shouldn't be backported to releases without testing.

Regards
Scott

On 2/04/2014, at 3:54 am, jler...@apache.org wrote:

Author: jleroux
Date: Tue Apr  1 14:54:12 2014
New Revision: 1583694

URL: http://svn.apache.org/r1583694
Log:
"Applied fix from trunk for revision: 1583689 "
------------------------------------------------------------------------
r1583689 | jleroux | 2014-04-01 16:52:23 +0200 (mar. 01 avr. 2014) | 4 lignes

A patch from Christian Carlow for "Include Thailand Province Geo data" 
https://issues.apache.org/jira/browse/OFBIZ-5607

This patch includes the CountryAddressFormat records for my Malaysia 
(OFBIZ-5606), Thailand, and Israel (OFBIZ-5609) geo issues.
Without this patch, the state/provinces do not appear in the dependent drop 
down form when adding party contact info.
------------------------------------------------------------------------


Modified:
    ofbiz/branches/release11.04/   (props changed)
ofbiz/branches/release11.04/framework/common/data/GeoData.xml

Propchange: ofbiz/branches/release11.04/
------------------------------------------------------------------------------
  Merged /ofbiz/trunk:r1583689

Modified: ofbiz/branches/release11.04/framework/common/data/GeoData.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/branches/release11.04/framework/common/data/GeoData.xml?rev=1583694&r1=1583693&r2=1583694&view=diff
==============================================================================
--- ofbiz/branches/release11.04/framework/common/data/GeoData.xml (original)
+++ ofbiz/branches/release11.04/framework/common/data/GeoData.xml Tue Apr  1 
14:54:12 2014
@@ -318,4 +318,7 @@ under the License.
     <GeoAssoc geoAssocTypeId="GROUP_MEMBER" geoIdTo="GBR" geoId="NIRL"/>
     <GeoAssoc geoAssocTypeId="GROUP_MEMBER" geoIdTo="GBR" geoId="WALS"/>

+ <CountryAddressFormat geoId="MYS" geoAssocTypeId="REGIONS" requireStateProvinceId="" requirePostalCode="" postalCodeRegex="" hasPostalCodeExt="" requirePostalCodeExt="" addressFormat=""/> + <CountryAddressFormat geoId="THA" geoAssocTypeId="REGIONS" requireStateProvinceId="" requirePostalCode="" postalCodeRegex="" hasPostalCodeExt="" requirePostalCodeExt="" addressFormat=""/> + <CountryAddressFormat geoId="ISR" geoAssocTypeId="REGIONS" requireStateProvinceId="" requirePostalCode="" postalCodeRegex="" hasPostalCodeExt="" requirePostalCodeExt="" addressFormat=""/>
</entity-engine-xml>





Reply via email to