[ https://issues.apache.org/jira/browse/OFBIZ-817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14228717#comment-14228717 ]
Swapnil Shah commented on OFBIZ-817: ------------------------------------ [~jacopoc] [~danielkunkel] Ideally we shouldn't use the MARKETING_PKG product types as its a parent product type for product types MARKETING_PKG_AUTO, MARKETING_PKG_PICK. Thus we have changed the logic in "getMktgPackagesAvailable" service to handle product types MARKETING_PKG_AUTO, MARKETING_PKG_PICK to handle the reported issues more gracefully. Following are the changes we have done in the service vis-a-vis RequireInventory=Y setting for Package and/or its components. Now at the time of add to cart : # if product type is MARKETING_PKG_AUTO then system will check it's own ATP instead of checking it's component ATP to allow or prevent placing order for package product.. # If product type is MARKETING_PKG_PICK then system will check it's component ATP to allow or prevent placing order for package product. Please find attached the patch for review that should address above mentioned fixes. > Require Inventory of Marketing Package Product can't be shipped > --------------------------------------------------------------- > > Key: OFBIZ-817 > URL: https://issues.apache.org/jira/browse/OFBIZ-817 > Project: OFBiz > Issue Type: Bug > Components: order > Affects Versions: Trunk > Environment: February 2007 svn > Reporter: Daniel Kunkel > Priority: Minor > Attachments: OFBIZ-817.patch > > > Setting Require Inventory for a Marketing Product and (or ???) its Marketing > Component causes the shiping system to fail. The shipping system reports > nothing is ready to ship, ( [0 + 0 = 0] < 1 ). > ---- exception report > ---------------------------------------------------------- > [TransactionUtil.setRollbackOnly] Calling transaction setRollbackOnly; this > stack trace shows where this is happening: > Exception: java.lang.Exception > Message: Error in simple-method [Quick ships an entire order from multiple > facilities [file:/wrk/ofbiz/ofbiz/applications/ > product/script/org/ofbiz/shipment/shipment/ShipmentServices.xml#quickShipEntireOrder]]: > ; [Warning: no shipments created; > could not find anything ready and needing to be shipped.] > ---- stack trace > --------------------------------------------------------------- > java.lang.Exception: Error in simple-method [Quick ships an entire order from > multiple facilities [file:/wrk/ofbiz/ofbiz/ > applications/product/script/org/ofbiz/shipment/shipment/ShipmentServices.xml#quickShipEntireOrder]]: > ; [Warning: no shipments > created; could not find anything ready and needing to be shipped.] > org.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:285) > org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:235) > org.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:697) > org.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:105) > org.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:87) > org.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:76) > org.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:51) > org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:340) > org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:211) > org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:113) > org.ofbiz.webapp.event.ServiceEventHandler.invoke(ServiceEventHandler.java:290) > org.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:409) -- This message was sent by Atlassian JIRA (v6.3.4#6332)