[
https://issues.apache.org/jira/browse/OFBIZ-5905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14262128#comment-14262128
]
Jacques Le Roux commented on OFBIZ-5905:
----------------------------------------
Hi Nicolas,
By "Convert createPartyRole to ensurePartyRole" I guess you mean to replace
createPartyRole implementation by ensurePartyRole implementation as I suggested?
For your other points I agree we need ensurePartyRoleFrom and
ensurePartyRoleThru. But I don't see a reason to keep the current
implementation of createPartyRelationshipAndRoles. So I guess by "Add a new
service createPartyRelationshipAndRoles" you mean to replace the current
implementation of createPartyRelationshipAndRoles, right?
BTW while at it we should replace the ensurePartyRole definition description by
its implementation description, thanks!
> Change createPartyRelationshipAndRole to use ensurePartyRole
> ------------------------------------------------------------
>
> Key: OFBIZ-5905
> URL: https://issues.apache.org/jira/browse/OFBIZ-5905
> Project: OFBiz
> Issue Type: Bug
> Components: party
> Affects Versions: Trunk
> Reporter: Gareth Carter
> Assignee: Nicolas Malin
> Priority: Minor
>
> createPartyRelationshipAndRole in party/servicedef/services.xml invokes
> createPartyRole and then createPartyRelationship. It would be better if
> createPartyRole was changed to ensurePartyRole so that
> createPartyRelationshipAndRole can be called without the risk of a duplicate
> key error in PartyRole
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
