[ https://issues.apache.org/jira/browse/OFBIZ-5758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14282021#comment-14282021 ]
Jacques Le Roux commented on OFBIZ-5758: ---------------------------------------- Here is the suggested patch {code} Index: applications/humanres/entitydef/entitymodel.xml =================================================================== --- applications/humanres/entitydef/entitymodel.xml (revision 1652873) +++ applications/humanres/entitydef/entitymodel.xml (working copy) @@ -597,10 +597,15 @@ title="Salary Step Entity"> <field name="salaryStepSeqId" type="id-ne"></field> <field name="payGradeId" type="id-ne"></field> + <field name="fromDate" type="date-time"></field> + <field name="thruDate" type="date-time"></field> <field name="dateModified" type="date-time"></field> <field name="amount" type="currency-amount"></field> + <field name="createdByUserLogin" type="id-vlong"></field> + <field name="lastModifiedByUserLogin" type="id-vlong"></field> <prim-key field="salaryStepSeqId"/> <prim-key field="payGradeId"/> + <prim-key field="fromDate"/> <relation type="one" fk-name="SLRY_STP_PGRD" rel-entity-name="PayGrade"> <key-map field-name="payGradeId"/> </relation> Index: applications/humanres/servicedef/services.xml =================================================================== --- applications/humanres/servicedef/services.xml (revision 1652873) +++ applications/humanres/servicedef/services.xml (working copy) @@ -288,6 +288,7 @@ <permission-service service-name="humanResManagerPermission" main-action="CREATE"/> <auto-attributes mode="IN" include="nonpk" optional="true"/> <attribute name="payGradeId" mode="IN" type="String"/> + <attribute name="fromDate" mode="IN" type="Timestamp"/> <attribute name="salaryStepSeqId" mode="OUT" type="String"/> </service> {code} I think the OOTB code is OK with that (it uses auto-attributes and auto-fields-entity) But this will need a comment at https://cwiki.apache.org/confluence/display/OFBIZ/Revisions+Requiring+Data+Migration+-+upgrade+ofbiz > SalaryStep entity missing From and Thru dates > --------------------------------------------- > > Key: OFBIZ-5758 > URL: https://issues.apache.org/jira/browse/OFBIZ-5758 > Project: OFBiz > Issue Type: Improvement > Components: humanres > Affects Versions: Trunk > Reporter: Al Cullen > > The SalaryStep entity is missing From and Thru dates which means that the > record for a SalaryStep can only hold the current value of the salary > This means, for example, that if a company wants to apply a 10% increase to > salary step value that is effective from a future date they currently would > have to wait until that date is reached before they could modify the value -- This message was sent by Atlassian JIRA (v6.3.4#6332)