[ 
https://issues.apache.org/jira/browse/OFBIZ-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288207#comment-14288207
 ] 

Jacques Le Roux commented on OFBIZ-1560:
----------------------------------------

Hi Daniel,

I know you are possibly no longer interested in this, but this was a good 
question, so here is my answer: X means all possible products in the cart (with 
same id).

For the remarks below I ordered 10 "WG-5569" products with your implementation 
and 11 with the current one. 

I have finally decided to not apply your patch. Because I found a regressive 
bug: if you use "Order Percent Discount" you get a lot of unrelated promotions. 
BTW same issue for "Order Percent Flat". This works well with the current 
implementation, where you have to take into account that *only* the "Is Greater 
Than" operator is *always* used, see my comment above on how to define the 
action rule. 

I will change the UI to explain what the current implentation really does: *it 
always and only uses the "Is Greater Than" operator*. WIth this information in 
the UI people should not be confused. Anyway with this operator you can easily 
do a "Is Greater Than or Equal to" operator by changing the "condition value". 
For instance if you want a break at 10 put 9 in the condition value, etc.

I noted also that when using "Gift with purchase", it's weird in both cases: if 
you ask for 1 product you get 8 :/ 

I will close this issue, if someone wants to improve to allow using the other 
operators then another issue should be created. But I believe it's usable as is 
because the other operators don't make much sense (if any) with this rule 
condition. IMO, Only the "Is Greater Than" and Is Greater Than or Equal to" 
operators make sense with "X Quantities of Product".


> Promotion rule for quantity discount not working
> ------------------------------------------------
>
>                 Key: OFBIZ-1560
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1560
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product, specialpurpose/ecommerce
>    Affects Versions: Trunk
>         Environment: Firefox 2.0, Ubuntu 7.10
>            Reporter: Raj Saini
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: OFBIZ-1560.patch, OFBIZ-1560.patch, OFBIZ-1560.patch
>
>
> Promotion rule for quantity discount does not work properly. For example if 
> the X product in shopping cart has Qty >= Y, apply  Z% discount to all the 
> quantities in the shopping cart. 
> I have created the following action to achieve the above:
> X Product for Y% discount - Can get the discounted price but this promotion 
> applies to every item i.e. it does not consider the minimum quantity limit.
> If I create the following condition:
> X quantity of Product  - It does apply the minimum quantity condition but 
> applies discount to the item above X. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to