Thanks Adrian for code review, I found warning on console, and found that in all places “OrderItemBilling” record was fetched with cache=false, if we want to override the OOTB behavior then we have to override the fetching logic as well. I found interesting thread: http://markmail.org/message/oqfzhzypsuteqawp
Thanks & Regards — Deepak Dixit > On Mar 18, 2015, at 4:34 PM, Adrian Crum <adrian.c...@sandglass-software.com> > wrote: > > What about when I decide to set never-cache to false on my local copy? > > Adrian Crum > Sandglass Software > www.sandglass-software.com > > On 3/18/2015 11:01 AM, dee...@apache.org wrote: >> Author: deepak >> Date: Wed Mar 18 11:01:25 2015 >> New Revision: 1667495 >> >> URL: http://svn.apache.org/r1667495 >> Log: >> Fixed OrderItemBilling cache warning, never-cache is set to true for >> OrderItemBilling, hence it will never put in cache. Set cache false while >> fetching the order item billing record in >> OrderReadHelper.getOrderPaymentReceivedTotalByType method. >> >> Modified: >> >> ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderReadHelper.java >> >> Modified: >> ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderReadHelper.java >> URL: >> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderReadHelper.java?rev=1667495&r1=1667494&r2=1667495&view=diff >> ============================================================================== >> --- >> ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderReadHelper.java >> (original) >> +++ >> ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderReadHelper.java >> Wed Mar 18 11:01:25 2015 >> @@ -1068,7 +1068,7 @@ public class OrderReadHelper { >> >> try { >> // get a set of invoice IDs that belong to the order >> - List<GenericValue> orderItemBillings = >> orderHeader.getRelated("OrderItemBilling", null, null, true); >> + List<GenericValue> orderItemBillings = >> orderHeader.getRelated("OrderItemBilling", null, null, false); >> Set<String> invoiceIds = new HashSet<String>(); >> for (GenericValue orderItemBilling : orderItemBillings) { >> invoiceIds.add(orderItemBilling.getString("invoiceId")); >> >>
