[ https://issues.apache.org/jira/browse/OFBIZ-6217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498033#comment-14498033 ]
Adrian Crum commented on OFBIZ-6217: ------------------------------------ Second patch committed in rev 1674064. Taher, Some parts of your patch would not apply, so I skipped those files. Also, you removed a finally block from DatabaseUtil.java, so I skipped that file. Removing a finally block is not an acceptable means to fix a compiler warning. There was one change that included a tab character. Be careful to use only spaces for indentation. I replaced the tab character with spaces. > fix warnings in trunk on java source code > ----------------------------------------- > > Key: OFBIZ-6217 > URL: https://issues.apache.org/jira/browse/OFBIZ-6217 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: Trunk > Reporter: Taher Alkhateeb > Assignee: Adrian Crum > Priority: Minor > Labels: java, warning > Fix For: Upcoming Branch > > Attachments: remove_unused_imports.patch, warnings_patch_2.patch, > warnings_patch_2.patch > > > Right now, we have 528 warnings on trunk out of which 238 are about raw types > and 118 never used imports. So we can already eliminate most of the warning > quite quickly. > I will issue multiple patches to resolve most of these warnings. It might be > a bit of a challenge to eliminate the raw types because the generics are not > always deducable from the code especially when relying on external APIs -- This message was sent by Atlassian JIRA (v6.3.4#6332)