Re: svn commit: r1678076 [2/3] - in /ofbiz/trunk/applications/product/config: ProductEntityLabels.xml ProductErrorUiLabels.xml

[Adam Heath]

Except that byte site is not equal to in-memory site.  Java doesn't use 
utf-8 internally to store character data.  I believe each char is 4 
bytes in size.  Then you have all the extra string objects with their 
char array pointing into the large shared blob.

On 05/06/2015 03:57 PM, Michael Brohl wrote:
- Posting in dev because I have no permission for commits -
Yes, thought about that recently when doing the german translations.

The drawback is that you have no overview about missing translations. 
It's easy to go through the files as they are now and add missing 
translations.

I quick checked the size of the *UILabels.xml files, they are about 
10.2 megs for all modules - not too much for today's servers with 
gigabytes of RAM.

So I think it is not worth the effort...

Michael

Am 06.05.15 um 21:50 schrieb Adam Heath:
Well, hmm.  Nothing at all wrong with this change, but I'd like to
discuss the pattern.

So, the way alternative languages are implemented, is that if I am
only concerned with *one* language, *all* languages have to be loaded
in memory.  Wouldn't it make more sense to split all these files into
per-language-specific versions, so that only languages that an
end-customer needs would have to be loaded into memory?

Then, the name of the file ends up using the very same fallback
mechanism for normal *.properties resources.

On 05/06/2015 02:35 PM, chr...@apache.org wrote:
Modified:
ofbiz/trunk/applications/product/config/ProductEntityLabels.xml
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/config/ProductEntityLabels.xml?rev=1678076&r1=1678075&r2=1678076&view=diff 

============================================================================== 


--- ofbiz/trunk/applications/product/config/ProductEntityLabels.xml
(original)
+++ ofbiz/trunk/applications/product/config/ProductEntityLabels.xml
Wed May  6 19:35:24 2015
@@ -388,6 +388,7 @@
          <value xml:lang="zh-TW">倉庫</value>
      </property>
      <property key="GoodIdentificationType.description.GOOGLE_ID">
+        <value xml:lang="de">Google Id</value>
          <value xml:lang="en">Google Id</value>
          <value xml:lang="it">Codice Google</value>
          <value xml:lang="ja">Google ID</value>
@@ -396,6 +397,7 @@
          <value xml:lang="zh-TW">谷歌用戶名</value>
      </property>
      <property key="GoodIdentificationType.description.ISBN">
+        <value xml:lang="de">ISBN</value>
          <value xml:lang="en">ISBN</value>
          <value xml:lang="es">ISBN</value>
          <value xml:lang="fr">ISBN</value>