Hi Adrian, Thanks for the feedback. That the existing patch files available in JIRA issues don't work in trunk has to do with the fact that the bootstrap dev branch is not in sync with trunk. We have to take in consideration that the framework stack of the bootstrap branch is based (for the greater part) on r1634810.
On top of that, the Bootstrap Basic and the other one were co-developed. And shortly before the disentanglement of the two themes changes in the templates were implemented for the other theme that affected the Bootstrap Basic theme negatively. Nonetheless, I am ok with whatever which way the community chooses to go with these bootstrap themes and the ones in trunk. It remains a personal preference what one likes best. Best regards, Pierre Smits *ORRTIZ.COM <http://www.orrtiz.com>* Services & Solutions for Cloud- Based Manufacturing, Professional Services and Retail & Trade http://www.orrtiz.com On Tue, Jun 23, 2015 at 5:20 PM, Adrian Crum < adrian.c...@sandglass-software.com> wrote: > I don't think the new themes are ready. I updated my local copy yesterday > and tried them out - many of the layout issues I reported still exist, plus > I found another one. > > I don't mind if there are just a few minor quirks - those can be fixed > after the themes are in the trunk, but right now there are too many. > > Also, we need to discuss how many themes we want to include in the trunk. > The Bootstrap Basic theme doesn't seem to get as much attention as the > other one, and it shows - its layout is much worse. I suggest we port over > one of the themes instead of two. > > Also, it would be nice to drop one or two existing themes. > > > Adrian Crum > Sandglass Software > www.sandglass-software.com > > On 6/23/2015 2:08 AM, Pierre Smits wrote: > >> Hi all, >> >> Recently we have seen that great strides have been made with respect to >> widget refactoring, theme functions disentanglement from framework ( >> OFBIZ-6362 <https://issues.apache.org/jira/browse/OFBIZ-6362>) and in the >> Bootstrap dev branch (OFBIZ-5840 >> <https://issues.apache.org/jira/browse/OFBIZ-5840>). >> >> Based on this all I am inclined to believe that both the Bootstrap Basic >> and the Bootstrap Sunrise themes are trunk ready. >> >> What do you think? >> >> Best regards, >> >> Pierre Smits >> >> *ORRTIZ.COM <http://www.orrtiz.com>* >> Services & Solutions for Cloud- >> Based Manufacturing, Professional >> Services and Retail & Trade >> http://www.orrtiz.com >> >>
