[
https://issues.apache.org/jira/browse/OFBIZ-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Becker updated OFBIZ-1032:
---------------------------------
Attachment: OFBIZ-1032_Remove-fallback-store.patch
I removed the unnecessary call to store after a failing create on
"mostly-inserts" activated. This call to store can never be successful, because
the running transaction is already marked rollback only because of the failed
create attempt. Instead it pollutes the log with additional errors.
The old patch in this issue uses a delegator API that does not exist, maybe
there had to be additional patches for that.
Conceptual I think, the data load with "mostly inserts" activated should fail
on a create-failure (what it does indeed already), so I see no need for a
working solution of a fallback store attempt. Consistently the Feature should
be renamed in the frontend from "mostly inserts" to "only inserts".
Additional trivial refactoring in the patch: I reduced the full qualified
classname of org.xml.sax.SAXException in method signatures to the simple name.
> EntitySaxReader mostly-insert (store after create-error) Fix
> ------------------------------------------------------------
>
> Key: OFBIZ-1032
> URL: https://issues.apache.org/jira/browse/OFBIZ-1032
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: Trunk
> Environment: Win XP
> Reporter: Karl Eilebrecht
> Assignee: Adam Heath
> Priority: Minor
> Attachments: OFBIZ-1032_Remove-fallback-store.patch, patch9675.patch
>
>
> This issue is part of Key-Work Ofbiz Contribution Proposal.
> http://docs.ofbiz.org/display/OFBIZ/Key-Work+Ofbiz+Contribution+Proposal
> Based on Release: 540035
> Includes: -
> Required: JIRA-1031, JIRA-1030, JIRA-1029, JIRA-1017, JIRA-1016
> Recommended: -
> Classes: EntitySaxReader
> Description: Avoids rollback on create error to be able to store the
> entity instead (mostly-inserts feature).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
