[ 
https://issues.apache.org/jira/browse/OFBIZ-6712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14992350#comment-14992350
 ] 

Jacques Le Roux commented on OFBIZ-6712:
----------------------------------------

BTW I Just re-read what I copied (for you) in OFBIZ-6210, and Jacopo has the 
same opinion than me.
{quote}
That is an interesting solution: however I am concerned that overloading the 
class loaders with all the lookups for entity/system resources could have an 
impact on performance and system's load.
I am not saying it is a bad idea, however I would feel more comfortable if 
these issues are fixed with the existing approach and then converted all at 
once into EntityClassLoader calls when we are sure we know the impact on 
performance (with profiling and performance tests).
{quote}

I agree with him that we should check the impact on performance. As I said in 
my comment, I expect the OS to take care of the caching, but that needs to be 
verified... Maybe a temporary performance test could be created?

> Increase the number of EntityUtilProperties methods which really use 
> getSystemPropertyValue()
> ---------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-6712
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6712
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Jacques Le Roux
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>
> Currently a number of EntityUtilProperties methods, notably  
> getPropertyNumber, 
> getPropertyAsBoolean/Integer/Long/Float/Double/BigInteger/BigDecimal, 
> propertyValueEquals (but not propertyValueEqualsIgnoreCase), etc. don't rely 
> on getSystemPropertyValue
> Note that getProperties methods are already covered by OFBIZ-6675
> If that would be done we could deprecate and ultimately replace 
> UtilProperties by EntityUtilProperties



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to