[ 
https://issues.apache.org/jira/browse/OFBIZ-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15006032#comment-15006032
 ] 

Jacques Le Roux commented on OFBIZ-5608:
----------------------------------------

Hi Gareth,

I did a similar search in Eclipse and got exactly the same result (15 entries). 
They are:

* FixedAsset
    ** expectedEndOfLife
    ** actualEndOfLife
* AcctgTransEntry
    ** dueDate
* JobRequisition
    ** jobRequisitionDate
    **  requiredOnDate
* JobInterview
    ** jobInterviewDate
* TechDataCalendarExcWeek
    ** exceptionDateStart
* OrderSummaryEntry
    ** entryDate
* Person
    ** birthDate
    ** deceasedDate
    ** passportExpireDate
* CustomTimePeriod
    ** fromDate
    ** thruDate
* TestFieldType
    ** dateField
* DateDimension
    ** dateValue


It seems to me that all these dates are plain dates (aka SQL 
Date/java.sql.Date) and not date-times (aka SQL 
TIMESTAMPTZ/java.sql.Timestamp). So no issues expected there.

I also did a research of {code}<date-time*type="date"*/>{code} in \*form\*.xml 
files and found 42 entries. So, it's a bit harder to review, not only because 
of the number but also because fields names speak less for themselves. I still 
expect that if the specific type="date" has been selected a SQL date is 
supposed, not a Timestamp.

For FTL templates it's finally easier than supposed. There is only 4 
shortDateInput=true cases, with 2 in Webtools. Unfortunately it does not seems 
to work correctly.
I noted this Adrian's comment in MacroFormRenderer:
// FIXME: modelFormField.getEntry ignores shortDateInput when converting Date 
objects to Strings.
This is another subject; so another issue should be created... A maybe related 
issue is if you set shortDateInput=true in order manager optionsettings.ftl, 
when you come back to the screen, the calendar button does not appear.

To summarize I believe we should make true by defaut the ignore-time-zone and 
specifically handle cases where it does not fit. They should not be many 
because they are anomalies if we consider that a plain date has no time 
associated.


> Dates Displaying Incorrectly With Negative Offest Timezones.
> ------------------------------------------------------------
>
>                 Key: OFBIZ-5608
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5608
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk
>            Reporter: Rupert Howell
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: IgnoreTimeZone.patch, ObjectTypeTests.patch, 
> dates.patch, dates_1589040.patch, sqldate_scenarios.png
>
>
> Dates are displaying incorrectly when negative offset (relative to UTC) are 
> applied by the users settings.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to