[ https://issues.apache.org/jira/browse/OFBIZ-5750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15007069#comment-15007069 ]
Jacques Le Roux edited comment on OFBIZ-5750 at 11/16/15 6:33 PM: ------------------------------------------------------------------ For this kind of services (CRUD or almost) my preference is minilang (it was created for that), but others may have other opinions ;) But wait, why do we need to reimplement createPartyRole, other cases like OFBIZ-6703? I was more thinking at the other changes done {quote} PostalAddressBoundary PartyClassification PartyClassificationGroup PartyAttribute Vendor PartyCarrierAccount {quote} but I (quickly) checked and found nothing to do for them. BTW, if it's necessary why not simply reuse what existed? was (Author: jacques.le.roux): For this kind of services my preference is minilang, but others may have other opinions ;) But wait, why do we need to reimplement createPartyRole? BTW why not simply reuse what existed? > Convert Party entites CRUD service from simple to entity-auto > ------------------------------------------------------------- > > Key: OFBIZ-5750 > URL: https://issues.apache.org/jira/browse/OFBIZ-5750 > Project: OFBiz > Issue Type: Improvement > Components: party > Affects Versions: Trunk > Reporter: Nicolas Malin > Assignee: Jacques Le Roux > Priority: Trivial > Labels: crud, entity-auto > Fix For: 14.12.01 > > Attachments: OFBIZ-5750.patch > > > I converted CRUD service to entity-auto for : > PartyRole > PostalAddressBoundary > PartyClassification > PartyClassificationGroup > PartyAttribute > Vendor > PartyCarrierAccount > Only entity with their services present on PartyServices.xml > I change the PartyRole attributes service like that > {code} > - <attribute name="partyId" type="String" mode="IN" optional="true"/> > - <attribute name="roleTypeId" type="String" mode="IN" > optional="false"/> > + <auto-attributes include="pk" mode="IN" optional="false"/> > {code} > The currently simple method haven't a specific resolution if the partyId > isn't pass, so the service failed with database constraint error. > I run manual test from Party Profile screen with success (except for > PostalAddressBoundary that haven't standard screen, so call by runService) > and I run ./ant clean-all load-demo run-tests without error -- This message was sent by Atlassian JIRA (v6.3.4#6332)