Like pierre suggested, we could call it: endDate or delimit or expire On Feb 6, 2016 2:54 PM, "Pierre Smits" <[email protected]> wrote:
> What about 'expire'? Seems also appropriate. > > Best regards, > > Pierre > > Op zaterdag 6 februari 2016 heeft Julien NICOLAS < > [email protected]> > het volgende geschreven: > > > I like the idea, when we call delete I imagine that the data is deleted > > from the database. > > > > As Gil said, cancel is not the word, close seems better. > > > > But, what's happen if I call delete ? Do you plan to delete all dependent > > entity ? > > > > Julien. > > > > Le 06/02/2016 17:09, gil portenseigne a écrit : > > > >> Hi, > >> > >> I'd propose "close", for closing de period where the data was active... > >> > >> But i'm not sure if this is not going too far, the algorithm beneath is > >> not quite simple to be an auto thing. When i develop i would prefer only > >> updating my GV after setting my closing date. > >> > >> What do you think ? > >> > >> Gil > >> > >> On 06/02/2016 10:18, Nicolas Malin wrote: > >> > >>> Hi guys, > >>> > >>> During the simple crud service to entity-auto, I detect the > >>> remove(Entity) service that didn't remove the generic value from the > data > >>> base put only set the field thruDate to now. > >>> > >>> I think this operation isn't in coherence with the service name, yes > >>> generally the operation is logical on context but not really on the > >>> abstract interface. I wish introduce a new operation on the entity-auto > >>> invocation : cancel (or an other nice word that you fell better). > >>> > >> > >> > >>> The idea, when you call cancel : > >>> * check if a field date is present on IN service fields and isn't a pk > >>> -> set at now > >>> * else check if a field like %statusId is present on IN service fields > >>> and isn't a pk -> check the related cancel status (if possible to > resolve > >>> it by the StatusType) > >>> * else check if a thruDate is present and isn't a pk and it's empty -> > >>> set at now > >>> * else check if a%thruDate is present and isn't a pk and it's empty -> > >>> set at now > >>> if one case match, call update > >>> > >>> After we would be use the pattern like cancelProductCategoryMember. > >>> > >>> <service name="cancelProductCategoryMember" engine="entity-auto" > >>> default-entity-name="ProductCategoryMember" invoke="cancel" > auth="true"> > >>> <description>Cancel a ProductCategoryMember</description> > >>> <permission-service service-name="genericProductPermission" > >>> main-action="UPDATE"/> > >>> <auto-attributes mode="IN" include="pk" optional="false"/> > >>> </service> > >>> > >>> As usual any suggest are welcome :) > >>> > >> > >> > > > > -- > Pierre Smits > > ORRTIZ.COM <http://www.orrtiz.com> > OFBiz based solutions & services > > OFBiz Extensions Marketplace > http://oem.ofbizci.net/oci-2/ >
