[ 
https://issues.apache.org/jira/browse/OFBIZ-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15222865#comment-15222865
 ] 

Jacques Le Roux commented on OFBIZ-4090:
----------------------------------------

If you are sure about what you do, why not indeed. 

But remember that the current simple-methods.xsd must miss the elements which 
were initially provided by the simple-methods-v2.xsd in the 
CompoundWidgetFiles.patch from 03/Jan/11 02:27. I try to find them but gave up. 
I think It should not be that hard to find and put them in our current 
simple-methods.xsd, but I did not :/.

Regarding splitting patches it's easier, for me at least, to have only 1 patch. 
Or if it's really hard to review several smaller patches in only one Jira 
issue. This at least if it makes sense from a functional perspective. Else 
better to create several Jira issues (seems not the case here).

It's fun to notice that by splitting issues and patches we would work contrary 
to what the compound screen feature try to avoid (opening, searcing in more 
files, etc.) :)

And last but not least, Adrian said that, even with his complete changes, the 
Eclipse auto-completion feature was not working properly. So It's interesting 
but I feel there are more work in your plate that maybe you envision ;)

Thanks to try anyway!




> Add Support For Compound Screen Widget XML Files
> ------------------------------------------------
>
>                 Key: OFBIZ-4090
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4090
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Adrian Crum
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: CompoundWidgetFiles.patch, CompoundWidgetFiles.patch, 
> OFBIZ-4090.patch
>
>
> Add the ability to include screen widgets, form widgets, menu widgets, and 
> simple methods in a single XML file. This approach could be used in 
> situations where the widgets share a logical grouping - so they can be kept 
> in one place.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to