[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15281312#comment-15281312
]
Taher Alkhateeb commented on OFBIZ-6783:
----------------------------------------
Oh sorry for the confusion, you did not understand me because I'm talking about
an earlier discussion. Let me make it clear below
If you look at our conversation above, you said "I will still prefer ant
start-debug". And if you look at the new build.xml which I'm going to send, it
will be exactly like you want it i.e. ant start-debug. I'm not changing ant
start-debug to ant debug. Instead what I'm changing is the arguments inside the
ant target start-debug. Specifically, I will change the argument --start-debug
to be --debug (which is passed to ofbiz.jar).
I hope this makes clear for you now. In short, all the ant targets are going to
remain the same. The only thing that changes is the arguments inside of them to
comply with the new requirements of jara -jar ofbiz.jar
> Refactor start.java
> -------------------
>
> Key: OFBIZ-6783
> URL: https://issues.apache.org/jira/browse/OFBIZ-6783
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: Upcoming Branch
> Reporter: Taher Alkhateeb
> Assignee: Taher Alkhateeb
> Labels: framework, main, refactoring, start
> Attachments: OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch,
> StartCommandUtil.java
>
>
> Looking at the main method and design of Start.java looks ugly. The things I
> would like to fix so far are:
> - the file is too long
> - some variables are not even needed (loaderArgs?)
> - the level of abstraction is wrong
> - main throws an exception!
> - the arguments processing logic is terrible, need to move it to commons-cli
> It's just so messy and ugly to look at. So for me refactoring starts at
> Start! Given that this is an important file, I will provide a patch to be
> reviewed by the community before committing just to be on the safe side.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
