[
https://issues.apache.org/jira/browse/OFBIZ-7091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15294872#comment-15294872
]
Swapnil M Mane commented on OFBIZ-7091:
---------------------------------------
Dear Deepak,
Thanks for reviewing patch and pointing out the thing, making perfect sense to
me :)
After looking at the code again, I think, this updated code block will address
the UI issue as well as the case of the update.
{code}
<#if carrierShippingMethod?has_content>
<option value = "${carrierShippingMethod!}">${carrierParty!}
${description}</option>
</#if>
<option value = ""> </option>
{code}
I request you to please review this updated code, if looks good, I will proceed
update the patch.
Thanks!
> Two empty options are shown in shipping method select box on Edit promo screen
> ------------------------------------------------------------------------------
>
> Key: OFBIZ-7091
> URL: https://issues.apache.org/jira/browse/OFBIZ-7091
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: Trunk
> Reporter: Swapnil M Mane
> Assignee: Pranay Pandey
> Priority: Trivial
> Attachments: EditProductPromoRules.png, OFBIZ-7091.patch
>
>
> On Edit promo screen, in existing condition section's select box two empty
> options are shown.
> Please find the screenshot for more detail.
> Reason and Solution:
> As per the code in EditProductPromoRules.ftl,
> {code}
> <option value =
> "${carrierShippingMethod!}">${carrierParty!} ${description}</option
> <option value = ""> </option>
> {code}
> And the carrierParty is calculated above, if it is not available the first
> option will show automatically as empty option
> {code}
> <option value =
> "${carrierShippingMethod!}">${carrierParty!} ${description}</option>
> {code}
> So, we don't need the second empty option field and can remove it.
> {code}
> <option value = ""> </option>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
