[ https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15300103#comment-15300103 ]
Jacques Le Roux commented on OFBIZ-6783: ---------------------------------------- Mmm wait, I confused, it's not the same kind of error, I lost myself working in 3 different WCs :/ Also I must say that I can really compare because "--test component=minilang --test suitename=MinilangTests" did not exist before... So no I don't reproduce the same with a WC w/o your changes, only the possible memory leaks. But I have the same with "ant run-tests" in an up to date WC. I also noticed that there are others differences with "-jar ofbiz.jar --test" and "ant run-tests" Notably the tests passes with a WC with changes for OFBIZ-6849 using "-jar ofbiz.jar --test" but not with "ant run-tests", we are both in troubles :D Courage, I continue... > Refactor the start component > ---------------------------- > > Key: OFBIZ-6783 > URL: https://issues.apache.org/jira/browse/OFBIZ-6783 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: Upcoming Branch > Reporter: Taher Alkhateeb > Assignee: Taher Alkhateeb > Labels: framework, main, refactoring, start > Attachments: OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, > OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, > OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, > OFBIZ-6783.patch, OFBIZ-6783.patch, StartCommandUtil.java, error.log, > ofbiz.log > > > Looking at the main method and design of Start.java and the start component > overall looks ugly. The things I would like to fix so far are: > - the files are too long > - some variables are not even needed (loaderArgs?) > - the level of abstraction is wrong > - main throws an exception! > - the arguments processing logic is terrible, need to move it to commons-cli > It's just so messy and ugly to look at. So for me refactoring starts at > Start! Given that this is an important component, I will provide a patch to > be reviewed by the community before committing just to be on the safe side. -- This message was sent by Atlassian JIRA (v6.3.4#6332)