[ 
https://issues.apache.org/jira/browse/OFBIZ-7112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-7112:
-----------------------------------
    Attachment: OFBIZ-7112.patch

Hi Wai,

Here find attached a slightly modifed version of your patch. I simply used 
UtilValidate.isEmpty() when possible and formatted the EntityQuery.use() calls 
as we normally do (easier reading, one was alredy too much indented, not 
yours). So there a no functional changes in this new attached patch.

Before that I tested your patch and all tests dont' pass. There are 5 which 
fails. Please have a look, thanks!


> EntityUtilProperties
> --------------------
>
>                 Key: OFBIZ-7112
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7112
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Wai
>            Assignee: Jacques Le Roux
>         Attachments: OFBIZ-7112.patch, OFBIZ-7112.patch, OFBIZ-7112.patch
>
>
> Ofbiz reads properties from either a properties file or the 
> entity:SystemProperty. The way it works previously is that ofbiz reads from 
> the entity:SystemProperty first and if there is no value associated with the 
> target propertyname, it would then locate the value from the relevant 
> properties file.
> In other words, if there is a database entry for a property, the database 
> entry should override the associated properties file.
> The issue is that if a database entry exist but the value is empty, it would 
> look for a value from the properties file.  It should not do so.  If a 
> database entry exists for the propertyname of interest, the value should be 
> taken from the database even if it holds an empty value.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to